Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TW-1162: Fix e2e tests #1015

Merged
merged 18 commits into from
Dec 7, 2023
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"start:manage_assets": "yarn start --tags @manage_assets",
"start:home": "yarn start --tags @home",
"start:create_new_wallet": "yarn start --tags @create_new_wallet",
"start:delegate": "yarn start --tags @create_new_wallet",
"start:delegate": "yarn start --tags @delegate",
"start:import_account_mnemonic": "yarn start --tags @import_account_mnemonic",
"start:import_account_private_key": "yarn start --tags @import_account_private_key",
"start:import_account_public_key": "yarn start --tags @import_account_public_key",
Expand Down
12 changes: 6 additions & 6 deletions e2e/src/page-objects/pages/drop-down-lists/networks.drop-down.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,6 @@ export class NetworksDropDown extends Page {
await this.networkItemButton.waitForDisplayed(timeout);
}

async selectNetwork(name: string) {
const networkItemElem = await findElement(NetworkSelectSelectors.networkItemButton, { name });

await networkItemElem.click();
}

async isClosed() {
await retry(
() =>
Expand All @@ -30,4 +24,10 @@ export class NetworksDropDown extends Page {
RETRY_OPTIONS
);
}

async selectNetwork(name: string) {
const networkItemElem = await findElement(NetworkSelectSelectors.networkItemButton, { name });

await networkItemElem.click();
}
}
3 changes: 2 additions & 1 deletion src/lib/ui/Popper.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import React, {
} from 'react';

import { Instance, Options, createPopper } from '@popperjs/core';
import classNames from 'clsx';
import useOnClickOutside from 'use-onclickoutside';

import Portal from 'lib/ui/Portal';
Expand Down Expand Up @@ -125,7 +126,7 @@ const Popper = memo<PopperProps>(({ popup, children, fallbackPlacementsEnabled =
{triggerNode}

<Portal>
<div ref={popupRef} className="z-40" style={style}>
<div ref={popupRef} className={classNames('z-40', !opened && 'hidden')} style={style}>
lendihop marked this conversation as resolved.
Show resolved Hide resolved
{popupNode}
</div>
</Portal>
Expand Down