Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TW-1180: Replace existing ads to slise xyz #1025

Merged
merged 8 commits into from
Dec 5, 2023
Merged

TW-1180: Replace existing ads to slise xyz #1025

merged 8 commits into from
Dec 5, 2023

Conversation

keshan3262
Copy link
Collaborator

No description provided.

@keshan3262 keshan3262 self-assigned this Nov 29, 2023
lendihop
lendihop reviewed Nov 29, 2023
View reviewed changes
src/contentScript.ts Outdated Show resolved Hide resolved
@keshan3262 keshan3262 requested a review from lendihop November 29, 2023 12:48
lendihop
lendihop previously approved these changes Nov 29, 2023
View reviewed changes
alex-tsx
alex-tsx reviewed Nov 29, 2023
View reviewed changes
src/replaceAds.tsx Outdated Show resolved Hide resolved
alex-tsx
alex-tsx reviewed Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@alex-tsx alex-tsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make sure, final bundled replaceAds.js is small & efficient (doesn't contain any React).

src/replaceAds.tsx Outdated Show resolved Hide resolved
alex-tsx
alex-tsx previously approved these changes Nov 30, 2023
View reviewed changes
@keshan3262 keshan3262 requested a review from lendihop November 30, 2023 15:18
lendihop
lendihop previously approved these changes Nov 30, 2023
View reviewed changes
@keshan3262 keshan3262 dismissed stale reviews from lendihop and alex-tsx via 6014e4c December 4, 2023 12:10
tttt24
tttt24 approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@tttt24 tttt24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chrome done

IrynaKhyzhynska
IrynaKhyzhynska approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@IrynaKhyzhynska IrynaKhyzhynska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

firefox done

@lourenc lourenc merged commit aa7a2cf into development Dec 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tttt24 tttt24 tttt24 approved these changes

@alex-tsx alex-tsx alex-tsx approved these changes

@lendihop lendihop lendihop approved these changes

@IrynaKhyzhynska IrynaKhyzhynska IrynaKhyzhynska approved these changes

Assignees

@keshan3262 keshan3262

Labels
qa approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@keshan3262 @IrynaKhyzhynska @lendihop @alex-tsx @tttt24 @lourenc