TW-687 Reduce balances loading from chain #1064
Conversation
keshan3262
had a problem deploying
to
development
GitHub Actions
Failure
keshan3262
temporarily deployed
to
development
GitHub Actions
Inactive
keshan3262
temporarily deployed
to
development
GitHub Actions
Inactive
keshan3262
temporarily deployed
to
development
GitHub Actions
Inactive
keshan3262
temporarily deployed
to
development
GitHub Actions
Inactive
| // Metadata may really be absent for some assets, see account tz1aSkwEot3L2kmUvcoxzjMomb9mvBNuzFK6 | ||
| // in Mainnet for example | ||
| return rawBalance == null ? undefined : atomsToTokens(new BigNumber(rawBalance), assetMetadata?.decimals ?? 0); |
There was a problem hiding this comment.
It will be safer to never assume decimals === 0. Our current policy is that absent metadata is metadata that has only failed to load.
Please, refer to the standard specs.
- FA-2 Tokens
https://tzip.tezosagora.org/proposal/tzip-12/#token-metadata
- FA-1.2 tokens
There was a problem hiding this comment.
Sorry, in our logic, failure of one token to load means failure of all tokens list to load, which is unacceptable.
There was a problem hiding this comment.
useBalance hook became very very convoluted & large (~200 lines of code) + other new definitions in this file. I think, it should be a rather simple hook, much smaller than this. Please, simplify it.
| return new Promise<BigNumber>((res, rej) => { | ||
| const unsubscribe = subscribeToActions(action => { | ||
| if (shouldUseTzkt) { | ||
| suspenseByReduxAction((action, stopSuspense) => { |
There was a problem hiding this comment.
Subscriptions to actions is still a very messy mechanism. Why do we need it at all? Can it be a simple throw like this?
if (someReduxStateLoadingFlag && thisFlagIsRelevantToTokenInInterest) throw new Promise(/* implementation here */)I refer to the way, SWR does this:
| export const useCurrentAccountAssetBalance = (slug: string) => { | ||
| const { publicKeyHash } = useAccount(); | ||
|
|
||
| const { data: balance } = useBalance(slug, publicKeyHash, { suspense: true }); |
There was a problem hiding this comment.
Suspence true is a change of logic here. Used to be without it
No description provided.