-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TW-1479: [EVM] Transactions history with Alchemy #1231
Merged
alex-tsx
merged 104 commits into
development-2
from
TW-1479-activity-history-with-alchemy
Dec 6, 2024
Merged
TW-1479: [EVM] Transactions history with Alchemy #1231
alex-tsx
merged 104 commits into
development-2
from
TW-1479-activity-history-with-alchemy
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransactions-history
…ransactions-history
…EVM] Applying metadata.
keshan3262
reviewed
Nov 25, 2024
alex-tsx
had a problem deploying
to
development
November 26, 2024 12:41 — with
GitHub Actions
Failure
lendihop
reviewed
Nov 26, 2024
lendihop
reviewed
Nov 26, 2024
lendihop
reviewed
Nov 26, 2024
lendihop
reviewed
Nov 26, 2024
alex-tsx
had a problem deploying
to
development
November 26, 2024 14:37 — with
GitHub Actions
Failure
keshan3262
approved these changes
Nov 26, 2024
lendihop
approved these changes
Nov 26, 2024
alex-tsx
had a problem deploying
to
development
November 28, 2024 16:25 — with
GitHub Actions
Failure
alex-tsx
force-pushed
the
TW-1479-activity-history-with-alchemy
branch
from
November 28, 2024 16:27
8563d25
to
a1541fd
Compare
keshan3262
reviewed
Nov 28, 2024
} | ||
}; | ||
}) as unknown as (changes: Storage.StorageAreaOnChangedChangesType) => void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
}) as unknown as (changes: Storage.StorageAreaOnChangedChangesType) => void; | |
}) as unknown as SyncFn<Storage.StorageAreaOnChangedChangesType>; |
Looks a bit prettier to me
lendihop
approved these changes
Nov 29, 2024
IrynaKhyzhynska
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://madfish.atlassian.net/browse/TW-1479