TW-760: [epic] NFT update #934
Conversation
src/app/pages/Collectibles/components/CollectibleBlur/index.tsx
Outdated
Show resolved
Hide resolved
alex-tsx
had a problem deploying
to
development
GitHub Actions
Failure
| @@ -702,6 +702,9 @@ | |||
| "send": { | |||
| "message": "Send" | |||
| }, | |||
| "floorPrice": { "message": "Floor" }, | |||
There was a problem hiding this comment.
because it's out of style
| titleI18nKey: TID; | ||
| } | ||
|
|
||
| export const TabsBar = React.forwardRef<HTMLDivElement, Props>(({ activeTabName, tabs, withOutline }, ref) => ( |
There was a problem hiding this comment.
the same, I think it's a little bit confusing that 2 components based on one file
There was a problem hiding this comment.
Only the one (TabsBar) is exported.
In this 53-lines-of-code file :)
There was a problem hiding this comment.
No matter how many exports have the file. when we write a lot of components and a lot of interfaces it makes the file too long and less understandable and readable, so I think we have to split them into small codes
|
|
||
| if (target.lt(0.01)) return toLocalFixed(bn.toPrecision(2)); | ||
|
|
||
| if (target.lt(10_000)) return toLocalFixed(bn, 2); |
There was a problem hiding this comment.
I heard that style of numbers like that 10_000 could lead to bugs in some cases
There was a problem hiding this comment.
Yes, this format is forbidden in TempleWallet Mobile. Not here, though
There was a problem hiding this comment.
So there are reasons for that..
vladvn1905
had a problem deploying
to
development
GitHub Actions
Failure
vladvn1905
had a problem deploying
to
development
GitHub Actions
Failure
vladvn1905
had a problem deploying
to
development
GitHub Actions
Failure
vladvn1905
had a problem deploying
to
development
GitHub Actions
Error
vladvn1905
temporarily deployed
to
development
GitHub Actions
Inactive
IrynaKhyzhynska
temporarily deployed
to
development
GitHub Actions
Inactive
No description provided.