NODE service get_table_data task is only allowed for published tables. #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanKarab
force-pushed
the
dev/MIP-825/get_table_data_should_use_the_guest_user
branch
4 times, most recently
from
00345c1 to
2b63a84
Compare
mollyk
approved these changes
Sep 21, 2023
KFilippopolitis
approved these changes
Sep 21, 2023
There was a problem hiding this comment.
Great job.
The tests are now simpler and smaller.
Two minor things:
- Update the README.md of node to also contain the PROTECT_LOCAL_DATA in the required env variables.
- Also add some test on the test_monet_db_facade.py to cover the different cases with the
use_public_user.
https://team-1617704806227.atlassian.net/browse/MIP-825 The 'get_table_data' task uses the db public user to fetch data so it only works for published data. Added 'use_public_user' parameter in the monetdb_facade method, so that the public user is used for the queries. Added 'get_table_data_from_db' method in the standalone tests (conftest.py) and changed all tests to use this method instead of calling the NODE task. Refactored many standalone tests to use ONLY the task they are testing, instead of using multiple NODE tasks to ensure the proper result. Instead direct DB queries are made. Added on/off switch named 'protect_local_data'. When the switch is on, the 'get_table_data' will use the public user, otherwise not. The GLOBALNODE should always have this variable switched off. In the LOCALNODE this variable should be off ONLY in testing scenarios.
ThanKarab
force-pushed
the
dev/MIP-825/get_table_data_should_use_the_guest_user
branch
from
2b63a84 to
fa60aef
Compare
ThanKarab
deleted the
dev/MIP-825/get_table_data_should_use_the_guest_user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://team-1617704806227.atlassian.net/browse/MIP-825
The 'get_table_data' task uses the db public user to fetch data so it only works for published data.
Added 'use_public_user' parameter in the monetdb_facade method, so that the public user is used for the queries.
Added 'get_table_data_from_db' method in the standalone tests (conftest.py) and changed all tests to use this method instead of calling the NODE task.
Refactored many standalone tests to use ONLY the task they are testing, instead of using multiple NODE tasks to ensure the proper result. Instead direct DB queries are made.