Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev/mip 897/add log transformation #487

Merged
merged 11 commits into from
Jul 10, 2024
Merged

Dev/mip 897/add log transformation #487

merged 11 commits into from
Jul 10, 2024

Conversation

mollyk
Copy link
Contributor

@mollyk mollyk commented Jun 17, 2024

Adds ability to use data transformations for PCA algorithm.

KFilippopolitis
KFilippopolitis requested changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@KFilippopolitis KFilippopolitis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
At the programming level some minor changes are needed.

exareme2/algorithms/exareme2/pca_with_tranformations.py Outdated Show resolved Hide resolved
exareme2/algorithms/exareme2/pca_with_tranformations.py Outdated Show resolved Hide resolved
exareme2/algorithms/exareme2/pca_with_tranformations.py Outdated Show resolved Hide resolved
exareme2/algorithms/exareme2/pca_with_tranformations.py Outdated Show resolved Hide resolved
exareme2/algorithms/exareme2/pca_with_tranformations.py Outdated Show resolved Hide resolved
exareme2/algorithms/exareme2/pca_with_tranformations.py Outdated Show resolved Hide resolved
tests/testcase_generators/testcase_generator.py Outdated Show resolved Hide resolved
@mollyk mollyk merged commit bddfea1 into master Jul 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KFilippopolitis KFilippopolitis KFilippopolitis approved these changes

@ThanKarab ThanKarab Awaiting requested review from ThanKarab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mollyk @KFilippopolitis