Split datasets to train datasets and validation datasets. #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThanKarab
reviewed
Jul 20, 2024
exareme2/controller/services/api/algorithm_request_validator.py
Outdated
Show resolved
Hide resolved
KFilippopolitis
force-pushed
the
updated_inputdata_with_validation_datasets
branch
from
05e6e85 to
0089a7c
Compare
ThanKarab
approved these changes
Jul 22, 2024
KFilippopolitis
force-pushed
the
updated_inputdata_with_validation_datasets
branch
from
0089a7c to
fd24d6f
Compare
ThanKarab
reviewed
Jul 23, 2024
| def _validate_data_model(requested_data_model: str, available_datasets_per_data_model): | ||
| if requested_data_model not in available_datasets_per_data_model.keys(): | ||
| raise BadUserInput(f"Data model '{requested_data_model}' does not exist.") | ||
| def _ensure_validation_criteria(validation_datasets: List[str], validation: bool): |
There was a problem hiding this comment.
In this context we don't know what validation is.
Rename to algorithm_specification_validation_flag ?
exareme2/controller/services/worker_landscape_aggregator/worker_landscape_aggregator.py
Show resolved
Hide resolved
exareme2/controller/services/worker_landscape_aggregator/worker_landscape_aggregator.py
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.