Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nashdoc tool #175

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add nashdoc tool #175

wants to merge 2 commits into from

Conversation

i4ki
Copy link
Collaborator

@i4ki i4ki commented Feb 17, 2017

No description provided.

Signed-off-by: Tiago <[email protected]>
Copy link
Member

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be cool do add some docs on this. But to be honest I was hoping to get the whole documentation thing for nash working properly before, things are kinda README/messy right now.

fmt.Println()
}

func lookFn(stdout, stderr io.Writer, fname string, pack string, pattern *regexp.Regexp) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why just the first parameters omits type ?

"testing"
)

type (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one type inside type() ? Some reason for this ? consistency ?

}

func TestDoc(t *testing.T) {
for _, test := range []testTbl{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show struct initialization with the field names some love :-), again kind'a hard to understand what is each of the fields.

"regexp"
)

const banner = `888b 888 888 888 888888
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AAAWWEESOMEEEEEEEE !!! lol


}

# carrr
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One a lisper always a lisper :-P

@i4ki
Copy link
Collaborator Author

i4ki commented Feb 18, 2017

Sorry about this code...

I just found this old branch on my computer and then I pushed it to remember to improve it...
Thanks for the review. I'll try to improve it soon.

@katcipis
Copy link
Member

Sorry to not be helping with more code yet, but I'm starting to hang around more, taking a look at the internal/sh package right now :-)

@ryukinix
Copy link
Member

nashdoc seems a nice thing. There is still some interesting in working on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants