-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nashdoc tool #175
base: master
Are you sure you want to change the base?
add nashdoc tool #175
Conversation
Signed-off-by: Tiago <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be cool do add some docs on this. But to be honest I was hoping to get the whole documentation thing for nash working properly before, things are kinda README/messy right now.
fmt.Println() | ||
} | ||
|
||
func lookFn(stdout, stderr io.Writer, fname string, pack string, pattern *regexp.Regexp) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why just the first parameters omits type ?
"testing" | ||
) | ||
|
||
type ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one type inside type() ? Some reason for this ? consistency ?
} | ||
|
||
func TestDoc(t *testing.T) { | ||
for _, test := range []testTbl{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Show struct initialization with the field names some love :-), again kind'a hard to understand what is each of the fields.
"regexp" | ||
) | ||
|
||
const banner = `888b 888 888 888 888888 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AAAWWEESOMEEEEEEEE !!! lol
|
||
} | ||
|
||
# carrr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One a lisper always a lisper :-P
Sorry about this code... I just found this old branch on my computer and then I pushed it to remember to improve it... |
Sorry to not be helping with more code yet, but I'm starting to hang around more, taking a look at the internal/sh package right now :-) |
|
No description provided.