Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pwd #244

Merged
merged 6 commits into from
Nov 12, 2017
Merged

Add pwd #244

merged 6 commits into from
Nov 12, 2017

Conversation

i4ki
Copy link
Collaborator

@i4ki i4ki commented Oct 1, 2017

So simple... do makes sense testing this?
I made a test, but feels like I'm testing os.Getwd and fmt.Println from Go.. there's no much code here.
Makes sense?

Closes #244

@codecov-io
Copy link

codecov-io commented Oct 1, 2017

Codecov Report

Merging #244 into master will decrease coverage by 0.1%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   57.05%   56.95%   -0.11%     
==========================================
  Files          26       27       +1     
  Lines        4403     4416      +13     
==========================================
+ Hits         2512     2515       +3     
- Misses       1651     1660       +9     
- Partials      240      241       +1
Impacted Files Coverage Δ
stdbin/mkdir/main.go 23.07% <23.07%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6779f6a...b4cb725. Read the comment docs.

@i4ki
Copy link
Collaborator Author

i4ki commented Oct 1, 2017

oops, the only code here is: https://github.com/NeowayLabs/nash/pull/244/files#diff-7e0bdb2b11a48277e00f1e8c58446148
the others are from #240 that I merged here also

go build $(buildargs) -o ./cmd/nashfmt/nashfmt ./cmd/nashfmt
cd cmd/nash && go build $(buildargs)
cd cmd/nashfmt && go build $(buildargs)
cd stdbin/mkdir && go build $(buildargs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be a big list 😅

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, we need to improve this =)

@vitorarins
Copy link
Member

@tiago4orion I agree that the code itself is really simple. But does it make sense to have a nash script testing the binary?

@i4ki
Copy link
Collaborator Author

i4ki commented Nov 12, 2017

@vitorarins The code is obviously right.

'avoiding bugs by avoiding code' seems to be the only true fact of computer science

@i4ki i4ki merged commit 0088976 into master Nov 12, 2017
@i4ki i4ki deleted the add-stdbin-pwd2 branch November 12, 2017 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants