-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pwd #244
Add pwd #244
Conversation
Signed-off-by: i4k <[email protected]>
Signed-off-by: i4k <[email protected]>
Signed-off-by: i4k <[email protected]>
Signed-off-by: i4k <[email protected]>
Signed-off-by: i4k <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #244 +/- ##
==========================================
- Coverage 57.05% 56.95% -0.11%
==========================================
Files 26 27 +1
Lines 4403 4416 +13
==========================================
+ Hits 2512 2515 +3
- Misses 1651 1660 +9
- Partials 240 241 +1
Continue to review full report at Codecov.
|
oops, the only code here is: https://github.com/NeowayLabs/nash/pull/244/files#diff-7e0bdb2b11a48277e00f1e8c58446148 |
go build $(buildargs) -o ./cmd/nashfmt/nashfmt ./cmd/nashfmt | ||
cd cmd/nash && go build $(buildargs) | ||
cd cmd/nashfmt && go build $(buildargs) | ||
cd stdbin/mkdir && go build $(buildargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be a big list 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, we need to improve this =)
@tiago4orion I agree that the code itself is really simple. But does it make sense to have a nash script testing the binary? |
@vitorarins The code is obviously right. 'avoiding bugs by avoiding code' seems to be the only true fact of computer science |
So simple... do makes sense testing this?
I made a test, but feels like I'm testing
os.Getwd
andfmt.Println
from Go.. there's no much code here.Makes sense?
Closes #244