Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add formal specification of the language #248

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

i4ki
Copy link
Collaborator

@i4ki i4ki commented Nov 12, 2017

This PR introduces the formal specification of the language.
What do you guys think? Is it better than EBNF?
The link to ohm editor with nash's gramar is here:
https://ohmlang.github.io/editor/#fca725147857c09bb442be1ce03048e0

Yes, there's some js to validate the grammar until ohm has a Go parser.
Still thinking the best way to install ohm-js dependency and run the grammar check from 'make test'.
Maybe ran with docker?

@i4ki i4ki requested review from katcipis and vitorarins November 12, 2017 09:03
@codecov-io
Copy link

codecov-io commented Nov 12, 2017

Codecov Report

Merging #248 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #248   +/-   ##
=======================================
  Coverage   56.85%   56.85%           
=======================================
  Files          27       27           
  Lines        4406     4406           
=======================================
  Hits         2505     2505           
  Misses       1657     1657           
  Partials      244      244

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0088976...6115b1d. Read the comment docs.

@ryukinix
Copy link
Member

Really interesting thing! I miss a lot checkers of EBNF grammar, I search a lot and didn't find anything really good; mostly just legacy, dead or just too painful too use. This ohm is a quite nice. I'm still think that ebnf is nice to read as human being, but have all that software of ohm doing the parsing, show-case of AST and other stuff is really great!

Seems pretty fine to me running the ohm tests inside of docker through make test. Formal tests it's important.

Copy link
Member

@vitorarins vitorarins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well I am a newbie in specification of languages. But this Ohm seems very visual, which I am very fond of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants