Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MNOE-857] Setup divisions when creating a new organization based on … #209

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MNOE-857] Setup divisions when creating a new organization based on … #209

wants to merge 2 commits into from

Conversation

MAhsenArif
Copy link
Contributor

…user role

@MAhsenArif MAhsenArif force-pushed the auto_assign_staff_division branch 2 times, most recently from f4a5d04 to 6d36585 Compare January 26, 2018 13:34
@MAhsenArif MAhsenArif force-pushed the auto_assign_staff_division branch from 6d36585 to 216a1cb Compare January 26, 2018 13:53
@ouranos ouranos requested review from ouranos and manu-d January 30, 2018 04:33
ouranos
ouranos requested changes Jan 30, 2018
View reviewed changes
Copy link
Contributor

@ouranos ouranos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature needs to be gated between the MnoeAdminConfig.isSubTenantEnabled() feature flag.

Otherwise LGTM.

src/app/views/customers/create-step-1/create-step-1.controller.coffee Outdated
@@ -26,6 +30,8 @@
# List of checked apps
vm.organization.app_nids = _.map(_.filter(vm.marketplace.apps, {checked: true}), 'nid') if MnoeAdminConfig.isAppManagementEnabled()

vm.organization.sub_tenant_ids = Object.keys vm.selectedSubTenants
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object.keys(vm.selectedSubTenants)

@MAhsenArif MAhsenArif force-pushed the auto_assign_staff_division branch from 41145b3 to 6a56970 Compare January 31, 2018 05:09
@MAhsenArif
Copy link
Contributor Author

@ouranos Encapsulated logic in MnoeAdminConfig.isSubTenantEnabled() feature flag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ouranos ouranos ouranos approved these changes

@manu-d manu-d Awaiting requested review from manu-d

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MAhsenArif @ouranos