Fix rejectStart, fix warnings

client/src/game/gameManager.d.tsx

@@ -1,5 +1,5 @@
 import { DoomsayerGuess } from "../menu/game/gameScreenContent/RoleSpecificMenus/LargeDoomsayerMenu";
-import GameState, { Phase, PhaseTimes, PlayerID, PlayerIndex, State, Verdict } from "./gameState.d";
+import { Phase, PhaseTimes, PlayerID, PlayerIndex, State, Verdict } from "./gameState.d";
 import { ToClientPacket, ToServerPacket } from "./packet";
 import { RoleOutline } from "./roleListState.d";
 

server/src/game/mod.rs

@@ -163,7 +163,7 @@ impl Game {
 
         //if there are no teams left and multiple amnesiacs alive then the game is not over
         if 
-            remaining_teams.len() == 0 && 
+            remaining_teams.is_empty() && 
             PlayerReference::all_players(self).into_iter()
                 .filter(|p|p.alive(self) && p.role_state(self).role() == role::Role::Amnesiac)
                 .collect::<Vec<_>>().len() > 1 

server/src/game/phase.rs

@@ -150,7 +150,7 @@ impl PhaseState {
                     // TODO send no trials left
                     Self::Evening { player_on_trial: None }
                 }else{
-                    Self::Voting { trials_left: trials_left }
+                    Self::Voting { trials_left }
                 }
             },
             &PhaseState::Evening { player_on_trial } => {

server/src/game/role/mod.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::single_match)]
+
 use crate::game::player::PlayerReference;
 use crate::game::visit::Visit;
 use crate::game::Game;

server/src/game/role/psychic.rs

@@ -51,13 +51,13 @@ impl RoleStateImpl for Psychic {
                         .filter(|p|p!=non_townie)
                         .collect::<Vec<_>>()
                         .choose_multiple(&mut rng, 2)
-                        .map(|p|*p)
+                        .copied()
                         .collect();
 
                     if let Some(random_player0) = random_players.get(0){
                         if let Some(random_player1) = random_players.get(1){
 
-                            let mut out = vec![non_townie, random_player0, random_player1];
+                            let mut out = [non_townie, random_player0, random_player1];
                             out.shuffle(&mut rng);
                             break 'a ChatMessage::PsychicEvil { players: [out[0].index(), out[1].index(), out[2].index()] }
                         }
@@ -77,7 +77,7 @@ impl RoleStateImpl for Psychic {
                         .collect::<Vec<_>>()
                         .choose(&mut rand::thread_rng()){
 
-                        let mut out = vec![townie, random_player];
+                        let mut out = [townie, random_player];
                         out.shuffle(&mut rng);
 
                         break 'a ChatMessage::PsychicGood { players: [out[0].index(), out[1].index()] }   

server/src/game/role_list.rs

@@ -117,7 +117,7 @@ pub enum RoleOutline {
 impl RoleOutline{
     pub fn get_all_possible_roles(&self, excluded_roles: &[RoleOutline], taken_roles: &[Role]) -> Vec<Role> {
         match self {
-            RoleOutline::Exact { role } => vec![role.clone()],
+            RoleOutline::Exact { role } => vec![*role],
             RoleOutline::FactionAlignment { faction_alignment } => {
                 Role::values().into_iter()
                     .filter(|r|r.faction_alignment() == *faction_alignment)

server/src/listener.rs

@@ -86,7 +86,7 @@ impl Listener{
             }else{
                 false
             }
-        ).map(|p|p.0.clone())
+        ).map(|p| *p.0)
     }
 
     pub fn on_connect(&mut self, connection: &Connection) {