Migrate to Vite + ESM #671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the advantage here? |
|
create react app is deprecated. Vite doesn’t support CJS in the next version |
|
I'll let Sammy review this one. He probably cares a lot more, and can talk to you easier. He will also probably put in the time to test it on his machine, which I don't have much of. But this looks pretty fine to me from skimming the code. |
|
It would be nice if something cleaner can be done about the language JSONs, though. |
|
I agree, but the valid languages had to be added to the array anyway. We could probably create an object for this. But this also allows for faster language switching |
Apersoma
added
the
Meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.