Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced role list #755

Merged
merged 9 commits into from
Jan 11, 2025
Merged

Enhanced role list #755

merged 9 commits into from
Jan 11, 2025

Conversation

Jack-Papel
Copy link
Collaborator

No description provided.

@Jack-Papel Jack-Papel marked this pull request as ready for review January 6, 2025 03:38
@Jack-Papel Jack-Papel changed the title Feature/enhanced role list Enhanced role list Jan 6, 2025
@Jack-Papel Jack-Papel requested a review from ItsSammyM January 7, 2025 03:51
ItsSammyM
ItsSammyM requested changes Jan 11, 2025
View reviewed changes
Copy link
Collaborator

@ItsSammyM ItsSammyM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes because your wincon and role tracking stuff doesnt work with reeducator
You saw me break it in person

client/src/components/gameModeSettings/OutlineSelector.tsx Outdated Show resolved Hide resolved
client/src/components/gameModeSettings/OutlineSelector.tsx Outdated Show resolved Hide resolved
server/src/game/mod.rs Show resolved Hide resolved
server/src/game/mod.rs Show resolved Hide resolved
server/src/game/player/mod.rs Outdated Show resolved Hide resolved
server/src/game/role_list.rs Outdated Show resolved Hide resolved
server/src/game/role_list.rs Show resolved Hide resolved
@ItsSammyM ItsSammyM merged commit afe13ad into main Jan 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsSammyM ItsSammyM ItsSammyM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jack-Papel @ItsSammyM