Clippy Cleanup II

[Jack-Papel]

This doesn't touch cop or ambusher, waiting til #764 is merged

This fixes warnings from the 'clippy' linter (the best linter) in preparation for @ItsSammyM getting his laptop set back up -- this way the transition to adding cargo clippy to his computer is not filled with yellow underlines.

If this is merged and Sam installs clippy, I might change the build action to check for clippy warnings too

[Apersoma]

why is it better to not use return?

[Apersoma]

To prevent merge conflicts, can you revert the changes made related to confusion & drunk aura, I'm going to make the same or equivalent changes in red herrings.

[Apersoma]

I'll put a comment on each file with a change.

[Apersoma]

Here

[Apersoma]

here

[Apersoma]

Its just those 2

[ItsSammyM]

I don't know how to review this

I need clippy on my computer first to review this
If you NEED to, merge this without my review. but then you have to click the big red "merge without review" button.

[Apersoma]

I fucked up the merge, and then reverted it but github still thinks its merged. How do I fix it?

[ItsSammyM]

Server tests fail

Also help me get clippy on my machine :P