Fix import from external jpeg images #12872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 24, 2017
magento-engcom-team
added
bugfix
Component: ImportExport
Reproduced on 2.1.x
fooman
reviewed
Dec 29, 2017
| @@ -161,6 +161,15 @@ public function move($fileName, $renameFileOff = false) | |||
| $read = $this->_readFactory->create($url, DriverPool::HTTPS); | |||
| } | |||
|
|
|||
| //only use filename (for URI with query parameters) | |||
| $parsedUrl = parse_url($url); | |||
There was a problem hiding this comment.
you could use the optional component parameter of parse_url here
$parsedUrl = parse_url($url, PHP_URL_PATH);
if ($parsedUrl) {
There was a problem hiding this comment.
True. I edited my code.
dmanners
approved these changes
Jan 2, 2018
This was referenced Jan 3, 2018
magento-team
pushed a commit
that referenced
this pull request
Jan 3, 2018
magento-engcom-team
added
the
Fixed in 2.3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unable to import products with external jpeg images hosted on a CDN with dynamic URLs not ending with ".jpg" or ".jpeg", e.g.
If accepted I'll create backport to 2.2 & 2.1.
Fixed Issues (if relevant)
Manual testing scenarios
Check all issues. My CSV in attachment.
products.csv.zip
Contribution checklist