Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento/magento2#39169: Special Price To Date is wrongly validated on applySpecialPrice #39690

Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
+3 −3
Open

magento/magento2#39169: Special Price To Date is wrongly validated on applySpecialPrice #39690

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9111182
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan Mar 1, 2025
364b4e5
Merge branch '2.4-develop' into fix-for-issue-39169
KrasnoshchokBohdan Mar 1, 2025
2a9dec5
Merge branch '2.4-develop' into fix-for-issue-39169
engcom-Hotel Mar 28, 2025
131815c
magento/magento2#39169: Special Price To Date is wrongly validated on…
KrasnoshchokBohdan Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2015 Adobe
* All Rights Reserved.
*/

namespace Magento\Framework\Stdlib\DateTime;
Expand Down Expand Up @@ -274,7 +274,7 @@ public function isScopeDateInInterval($scope, $dateFrom = null, $dateTo = null)
$scopeTimeStamp = $this->scopeTimeStamp($scope);
$fromTimeStamp = strtotime($dateFrom);
$toTimeStamp = strtotime($dateTo);
if ($dateTo) {
if ($dateTo && date('H:i:s', strtotime($dateTo)) === '00:00:00') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will have the same +1 day result if use '00:00:00' in the API query. I'm not sure that it's correct solution

// fix date YYYY-MM-DD 00:00:00 to YYYY-MM-DD 23:59:59
$toTimeStamp += 86400;
}
Expand Down