Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Bootstrap under Mack Hypothesis. #76

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

lrnv
Copy link

@lrnv lrnv commented Sep 8, 2020

This adds :

1° A S3 class BootMackChainLadder and some methods (print, summary, mean, CDR)
2° A S3 class MultiBootMackChainLadder and some methods (mean, CDR, NyIBNR, Corel)


From our discussions, I extracted the following todos:

  • Clean the issue page
  • Rebase the branch
  • Add message in NEWS.md
  • Merge the vignette and rewrite it completely
  • Check the documentation and code for french, and english mistakes.
  • Output: When printing the model, it should look more like MackChainLadder;
  • BMCL results: NyInc before NyCum ; Totals are characters ????
  • Look in BootstrapReserve files for functions at the end of the file: remove as much as possible. -> This is not possible as the functions are not the same at all. Changing them would be a pain.
  • Put references in the docuentation according to MackChainLadder.Rd -> ligne 142.
  • Reproduce Devineau's example in the documentation @examples sections: adds credibility. Show that the variance is macks
  • See MackChainLadder documentation and rewrite my documenttion to match it.
  • Write some examples from Devinau & al as tunit tests / use a triangle in the package. See inst/unitTests/runit.MackChainLadder.R for the procedure of writing these tests. 5 to 10 tests : diferent parameters etc. The starting points are the examples in the documentation.
  • Rebase and cherry-pick commits at the end before merging.

lrnv added 5 commits March 9, 2021 12:26
This is not ready to be merged yet, this still needs some work.
Some fixing in the documentation, removing the french in the coments and the code.
There were also some typo in the docs and in the examples.
We also ran styler and improved the documentation.
We added copyright info to the code.
We removed flaky documentation that was not allowing r cmd check to pass.
It now describes more deeply the code that was added.
Later, this vignette would need to be moved to the package docs..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant