Fix -Wtautological-constant-out-of-range-compare warnings

magiblot · Nov 8, 2023 · e9fac37 · e9fac37
1 parent 9045dda
commit e9fac37
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/source/platform/far2l.cpp b/source/platform/far2l.cpp
@@ -79,10 +79,10 @@ ParseResult parseFar2lInput(GetChBuf &buf, TEvent &ev, InputState &state) noexce
     enum { k = 32 };
     char s[4*k];
     size_t len = 0;
-    char c;
+    int c;
     while (c = buf.getUnbuffered(), c != -1 && c != '\x07')
         if (len < sizeof(s))
-            s[len++] = c;
+            s[len++] = (char) c;
     char o[3*k];
     TStringView out = decodeBase64({s, len}, o);
     if (!out.empty())

diff --git a/source/platform/terminal.cpp b/source/platform/terminal.cpp
@@ -864,10 +864,10 @@ char *TermIO::readUntilBelOrSt(GetChBuf &buf) noexcept
 {
     size_t capacity = 1024;
     size_t len = 0;
-    char prev = '\0';
     if (char *s = (char *) malloc(capacity))
     {
-        char c;
+        int prev = '\0';
+        int c;
         while (c = buf.getUnbuffered(), c != -1)
         {
             if (c == '\x07') // BEL
@@ -885,7 +885,7 @@ char *TermIO::readUntilBelOrSt(GetChBuf &buf) noexcept
                     s = (free(s), nullptr);
             }
             if (s)
-                s[len++] = c;
+                s[len++] = (char) c;
             prev = c;
         }
         if (s)