Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tarpaulin code coverage and add .vscode to gitignore #188

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

jonZlotnik
Copy link
Contributor

the github action for tarpauling breaks often, and it's not worth depending on it when it's just as easy (and more transparent) to run it using the cargo action

evidence of frequent breakage:
actions-rs/tarpaulin#15
actions-rs/tarpaulin#23

@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch coverage: 72.64% and project coverage change: +0.08 🎉

Comparison is base (5778854) 43.18% compared to head (a82a7ae) 43.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #188      +/-   ##
==========================================
+ Coverage   43.18%   43.27%   +0.08%     
==========================================
  Files          17       18       +1     
  Lines        2554     2542      -12     
==========================================
- Hits         1103     1100       -3     
+ Misses       1451     1442       -9     
Impacted Files Coverage Δ
src/forwarding.rs 0.00% <0.00%> (ø)
src/transit/crypto.rs 43.26% <12.00%> (-6.08%) ⬇️
src/transfer/v1.rs 34.34% <50.00%> (-0.44%) ⬇️
src/transfer.rs 40.20% <75.00%> (-1.10%) ⬇️
src/util.rs 37.25% <80.00%> (+1.83%) ⬆️
src/transit.rs 75.24% <80.59%> (-0.86%) ⬇️
src/transit/transport.rs 84.53% <84.53%> (ø)
src/core/rendezvous.rs 74.01% <100.00%> (+0.98%) ⬆️
src/transfer/messages.rs 55.55% <0.00%> (-3.07%) ⬇️
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jonZlotnik jonZlotnik marked this pull request as ready for review March 7, 2023 04:45
Copy link
Member

@piegamesde piegamesde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. One minor thing: please split out the gitignore change into a separate commit.

@piegamesde piegamesde merged commit 32369ac into magic-wormhole:master Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants