This repository has been archived by the owner on Aug 16, 2024. It is now read-only.
Feat/53 make all cli flag inputs case insensitive #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesrp13
suggested changes
Oct 26, 2023
There was a problem hiding this comment.
The flag itself should not be case insensitive, it's the values provided that we want to be case insensitive. Even then, we need to not adjust the values provided because e.g. the api key is probably case sensitive. It's just the values that we are comparing againts (e.g. login methods) that we want to be a little more intelligent with. For example, if we expect EmailOTP and they put emailOTP we should still be able to parse that
|
@jamesrp13 Please review the new changes. |
AdityaKulkarni
deleted the
feat/53-make-all-cli-flag-inputs-case-insensitive
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Pull Request