Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add username data field to metadata call response #127

Merged
merged 1 commit into from
Apr 23, 2024
Merged

feat: add username data field to metadata call response #127

merged 1 commit into from
Apr 23, 2024

Conversation

am-hernandez
Copy link
Member

📦 Pull Request

The username field was added to the user metadata and now the Admin SDK needs to consume this and return it to the developer.

✅ Fixed Issues

  • Ticket
    • adds username to metadata return value and MagicUserMetadata interface
    • adds username to tests to getMetadataByIssuer.spec.ts

🚨 Test instructions

⚠️ Don't forget to add a semver label!

@am-hernandez am-hernandez merged commit 1e70e7e into master Apr 23, 2024
1 check passed
@am-hernandez am-hernandez deleted the PDEEXP-856-Add-WebAuthn-Metadata branch April 23, 2024 15:59
@Ethella
Copy link
Member

Ethella commented Apr 23, 2024

🚀 PR was released in v2.4.1 🚀

@Ethella Ethella added the released This issue/pull request has been released. label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hcote hcote hcote approved these changes

@Ethella Ethella Awaiting requested review from Ethella

@damianjachyra damianjachyra Awaiting requested review from damianjachyra

Assignees
No one assigned
Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@am-hernandez @Ethella @hcote