Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase major version #856

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Increase major version #856

merged 1 commit into from
Mar 3, 2025

Conversation

joshuascan
Copy link
Member

@joshuascan joshuascan commented Mar 3, 2025

📦 Pull Request

This version bundles together the changes from 28.21.0 and 28.21.1 into a new major version as the former minor version included breaking changes. These two versions will be marked as deprecated and the changes from them are:

  • Removes legacy third party wallet logic
  • Adds new web3modal extension which handles the wallet connection request & EIP1193 listeners
  • Adds new thirdPartyWallet module which handles isConnected to third party wallet state & rpc routing to wallets
  • Updates request function to route payload to third party wallet if connected
  • Fixes issue where users were unable to scroll on iOS safari

✅ Fixed Issues

  • [List any fixed issues here like: Fixes #XXXX]

🚨 Test instructions

[Describe any additional context required to test the PR/feature/bug fix.]

⚠️ Don't forget to add a semver label!

Please 🚨 ONLY ADD ONE 🚨 of the following labels, failing to do so may lead to adverse versioning of your changes when published:

  • patch: Bug Fix?
  • minor: New Feature?
  • major: Breaking Change?
  • skip-release: It's unnecessary to publish this change.

Special Note

Please avoid adding any of the Priority labels as they conflict with the labels above ☝️

@joshuascan joshuascan added the major Increment the major version when merged label Mar 3, 2025
@joshuascan joshuascan requested a review from a team as a code owner March 3, 2025 18:39
@joshuascan joshuascan changed the title chore: change readme Increase major version Mar 3, 2025
@joshuascan joshuascan added this pull request to the merge queue Mar 3, 2025
Merged via the queue into master with commit 5026782 Mar 3, 2025
6 checks passed
@joshuascan joshuascan deleted the major-bump branch March 3, 2025 18:52
@Ethella Ethella added the released This issue/pull request has been released. label Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major Increment the major version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants