Skip to content

Commit

Permalink
transient--suspend-override: Assert transient--window is still live
Browse files Browse the repository at this point in the history
It should be, but something else might mess with it.

Helm's completing-read function does mess with it.  It *appears*
(I haven't investigated further) that it tries to use our window,
but because we prevent that, it instead deletes that window and
creates its own window.  It does however bring back our buffer,
when done.  Still, we cannot assume here that our window is live.

Closes the second coming of #656.
  • Loading branch information
tarsius committed Feb 21, 2025
1 parent 3c6efe8 commit 3cd02ec
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lisp/transient.el
Original file line number Diff line number Diff line change
Expand Up @@ -2604,6 +2604,7 @@ value. Otherwise return CHILDREN as is.")
(transient--timer-cancel)
(let ((show (if nohide 'fixed transient-show-during-minibuffer-read)))
(when (and (integerp show)
(window-live-p transient--window)
(< (frame-height (window-frame transient--window))
(+ (abs show)
(window-height transient--window))))
Expand Down

0 comments on commit 3cd02ec

Please sign in to comment.