Change detection of /etc/shadow
#412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a work-around for file_exists() not working when infection/include-interceptor is loaded.
Ocramius
approved these changes
Sep 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work-around for
file_exists()not working when infection/include-interceptor is loaded.https://github.com/infection/include-interceptor/blob/afdc4767617594ba745067505573b4bb358e1e14/src/IncludeInterceptor.php#L385
This calls
is_readable(), but we specifically need a file which exists (hence callingfile_exists()), but is not readable. This change works around this limitation in theinfectionframework/tooling. Ideally we'd find a file which is known to exist and be unreadable on eachPHP_OS_FAMILYto make the tests more portable.This should squash the last mutant being reported in #388.