Skip to content

Commit

Permalink
tweak gui to make meter allign with knobs
Browse files Browse the repository at this point in the history
for new win height
  • Loading branch information
magnetophon committed Nov 4, 2024
1 parent fd8a6ca commit ac2bac5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 11 deletions.
2 changes: 0 additions & 2 deletions src/editor/dual_meter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ const TEXT_TICKS: [i32; 6] = [-80, -60, -40, -20, 0, 12];

/// A simple horizontal dual meter.
///
/// TODO: There are currently no styling options at all
/// TODO: Vertical dual meter, this is just a proof of concept to fit the gain GUI example.
pub struct DualMeter;

/// The bar bit for the dual meter, manually drawn using vertical lines.
Expand Down
5 changes: 0 additions & 5 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -896,8 +896,6 @@ impl Plugin for Del2 {
output[1][sample_idx] *= dry;
}

// TODO: Some form of band limiting
// TODO: Filter
for delay_tap in self.delay_taps.iter_mut().filter_map(|v| v.as_mut()) {
let tap_index = delay_tap.tap_index;
let note = self.delay_data.notes[tap_index];
Expand Down Expand Up @@ -1297,10 +1295,7 @@ impl Del2 {
}
}

// TODO: when the fade time is long, there are bugs with taps not appearing, or fading out while fading in, etc.
// more testing is needed
// for fn initialize():

fn calculate_buffer_size(&self, buffer_size: u32) -> u32 {
((TOTAL_DELAY_SAMPLES as f64 / buffer_size as f64).ceil() as u32 * buffer_size)
.next_power_of_two()
Expand Down
8 changes: 4 additions & 4 deletions src/style.css
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ generic-ui .label {
}

.peak-meter-group {
height: 78px;
height: 85px;
left: 0px;
right: 9px;
top: 3px;
Expand All @@ -167,7 +167,7 @@ generic-ui .label {
dual-meter {
/* width: 584px; */
width: 1s;
height: 21px;
height: 25px;
color: #e0ce91;
left: 0px;
bottom: 0px;
Expand Down Expand Up @@ -200,8 +200,8 @@ dual-meter .ticks__label {

.peak-meter-label-group {
right: 9px;
top: 6px;
bottom: 24px;
top: 2px;
bottom: 22px;
font-size: 16;
width: 29px;
}

0 comments on commit ac2bac5

Please sign in to comment.