Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft of eGPIO SHIM #2

Closed
wants to merge 8 commits into from
Closed

Draft of eGPIO SHIM #2

wants to merge 8 commits into from

Conversation

magp-nordic
Copy link
Owner

No description provided.

@magp-nordic magp-nordic mentioned this pull request Jun 11, 2024
Closed
@magp-nordic
Copy link
Owner Author

magp-nordic commented Jun 13, 2024 •
edited
Loading

Blinky sample builds without errors, rebased on zephyrproject-rtos#73024
Only the last three commits are valid

@masz-nordic
Copy link

Can you rebase main as well? Webpage is lagging for me with this many changes.

@magp-nordic magp-nordic marked this pull request as ready for review June 13, 2024 15:56
@magp-nordic
manifest: update hal_nordic version
e565bdf 
Update hal_nordic with headers for eGPIO.

Signed-off-by: Magdalena Pastula <[email protected]>
@magp-nordic
dts: bindings: add new binding for eGPIO
81dd81f 
Add binding for emulated GPIO.

Signed-off-by: Magdalena Pastula <[email protected]>
@magp-nordic magp-nordic force-pushed the NRFX-5848-add-gpio-edriver branch 2 times, most recently from 5aaa08a to 1666556 Compare June 17, 2024 09:33
masz-nordic
masz-nordic reviewed Jun 17, 2024
View reviewed changes
Copy link

@masz-nordic masz-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few minor comments.
Could you run code formatter to get rid of the compliance fails?

drivers/gpio/CMakeLists.txt Outdated Show resolved Hide resolved
samples/basic/blinky/prj.conf Outdated Show resolved Hide resolved
drivers/gpio/egpio_nrfx.c Outdated Show resolved Hide resolved
drivers/gpio/egpio_nrfx.c Outdated Show resolved Hide resolved
drivers/gpio/egpio_nrfx.c Outdated Show resolved Hide resolved
drivers/gpio/egpio_nrfx.c Outdated Show resolved Hide resolved
jaz1-nordic pushed a commit to jaz1-nordic/zephyr that referenced this pull request Jun 17, 2024
@magp-nordic @jaz1-nordic
drivers: add eGPIO SHIM
c26107d 
Cherry-picked from magp-nordic/pull/2 with my local changes.

Signed-off-by: Magdalena Pastula <[email protected]>
Signed-off-by: Jakub Zymelka <[email protected]>
jaz1-nordic pushed a commit to jaz1-nordic/zephyr that referenced this pull request Jun 17, 2024
@magp-nordic @jaz1-nordic
drivers: add eGPIO SHIM
12b8b21 
Cherry-picked from magp-nordic/pull/2 with my local changes.

Signed-off-by: Magdalena Pastula <[email protected]>
Signed-off-by: Jakub Zymelka <[email protected]>
@magp-nordic magp-nordic force-pushed the NRFX-5848-add-gpio-edriver branch 2 times, most recently from 902e84a to 01a1270 Compare June 17, 2024 14:10
masz-nordic
masz-nordic reviewed Jun 17, 2024
View reviewed changes
drivers/gpio/gpio_nrfe.c Outdated Show resolved Hide resolved
drivers/gpio/gpio_nrfe.c Show resolved Hide resolved
modules/hal_nordic/nrfe/Kconfig Outdated Show resolved Hide resolved
@magp-nordic
modules: hal_nordic: add option for emulated peripherals drivers
6501e3c 
Add Kconfig option for emulated peripherals drivers support.

Signed-off-by: Magdalena Pastula <[email protected]>
@magp-nordic
soc: nordic: nrf54l: add support for NRFE
c338da4 
Add support for emulated peripherals on nRF54L15 APP.

Signed-off-by: Magdalena Pastula <[email protected]>
@magp-nordic magp-nordic force-pushed the NRFX-5848-add-gpio-edriver branch 2 times, most recently from cdca068 to 4ac04c2 Compare June 18, 2024 15:20
@magp-nordic
dts: arm: nordic: nRF54L15: add egpio node
1476963 
Add node for emulated gpio in nRF54L15 APP dts.

Signed-off-by: Magdalena Pastula <[email protected]>
@magp-nordic
soc: nordic: nrf54l: change init priority for eGPIO
117df50 
Change default init priority for emulated GPIO, so that it is
initialized after IPC.

Signed-off-by: Magdalena Pastula <[email protected]>
@magp-nordic
drivers: gpio: add eGPIO driver
3335c81 
Add driver for emulated GPIO.

Signed-off-by: Magdalena Pastula <[email protected]>
@magp-nordic
samples: basic: blinky: modify to use eGPIO
c4ef8ae 
Modify blinky sample to use emulated GPIO.

Signed-off-by: Magdalena Pastula <[email protected]>
@magp-nordic
Copy link
Owner Author

Moved to: masz-nordic#1

jaz1-nordic pushed a commit to jaz1-nordic/zephyr that referenced this pull request Jun 24, 2024
@magp-nordic @jaz1-nordic
drivers: add eGPIO SHIM
c63639b 
Cherry-picked from magp-nordic/pull/2 with my local changes.

Signed-off-by: Magdalena Pastula <[email protected]>
Signed-off-by: Jakub Zymelka <[email protected]>
jaz1-nordic pushed a commit to jaz1-nordic/zephyr that referenced this pull request Jun 24, 2024
@magp-nordic @jaz1-nordic
drivers: add eGPIO SHIM
6d144ac 
Cherry-picked from magp-nordic/pull/2 with my local changes.

Signed-off-by: Magdalena Pastula <[email protected]>
Signed-off-by: Jakub Zymelka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masz-nordic masz-nordic Awaiting requested review from masz-nordic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magp-nordic @masz-nordic