-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specialized components and port old components to new architecture #81
Conversation
The I think this pattern is a reasonable compromise between code reuse and usability. |
Should the specialized component traits and helper structs rather be kept inside their respective modules? For example, Also, should we maybe split What do you think, @luleyleo? |
I think that would be nice.
Having submodules like |
Regarding this: |
I would like to keep it either as a kind of |
82282cd
to
3796b7f
Compare
This has become a very large PR, with more than 4000 lines changed, but I think this is appropriate.
@HeleNoir Please have a look especially at @luleyleo, I briefly looked at #88 and I think we have some overlapping functionality. I think a rebase of your branch would be good after we have sorted out this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find any other issues (but I'm not that well-versed in Rust), so we should wait for @luleyleo to approve as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall. A few nits to pick and then we can merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good now 👍🏻
Closes #80, closes #85.
Ported modules: