fix(sn_node): do not cast handover vote after aggregated

sn_interface/src/network_knowledge/section_authority_provider.rs

@@ -89,6 +89,14 @@ impl SapCandidate {
             }
         }
     }
+
+    pub fn public_key_set(&self) -> PublicKeySet {
+        match self {
+            SapCandidate::ElderHandover(sap) => sap.public_key_set(),
+            // TODO: consider return both?
+            SapCandidate::SectionSplit(sap1, _sap2) => sap1.public_key_set(),
+        }
+    }
 }
 
 impl Debug for SectionAuthorityProvider {

sn_node/src/bin/safenode/main.rs

@@ -353,7 +353,7 @@ fn monitor_node_events(
                 }
                 _ => {
                     /* we are not interested in any other type of node events here */
-                    info!("Received an un-interested node event {event:?}");
+                    info!("Dropping an event we currently don't expose through gRPC: {event:?}");
                 }
             }
         }

sn_node/src/node/handover/handover_consensus.rs

@@ -43,6 +43,12 @@ impl Handover {
     }
 
     pub(crate) fn propose(&mut self, proposal: SapCandidate) -> Result<SignedVote<SapCandidate>> {
+        // Do not cast a vote equals to self sap
+        if self.consensus.elders == proposal.public_key_set() {
+            error!("Cannot casting a proposal {proposal:?} as we are already on it");
+            return Err(Error::FaultyProposal);
+        }
+
         let vote = Vote {
             gen: self.gen,
             ballot: Ballot::Propose(proposal.clone()),

sn_node/src/node/messaging/dkg.rs

@@ -863,15 +863,6 @@ impl MyNode {
             }
         }
 
-        // // Do we really need this update currently?
-        // // Shall the update only get carried out when the network_knowledge has the chain key?
-        // match self.update_on_sap_change(&self.context()).await {
-        //     Ok(update_cmds) => cmds.extend(update_cmds),
-        //     Err(err) => {
-        //         error!("Failed on handle DKG outcome of {key_share_pk:?} during knowledge update: {err:?}")
-        //     }
-        // }
-
         Ok(cmds)
     }
 }