-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] chore: ensure testnet launch fails if build fails #2268
base: main
Are you sure you want to change the base?
Conversation
AI-Generated Summary: This pull request includes four patches:
|
Reviewpad Report
This reverts commit 0765b53.' (cbf6b14)
This reverts commit 70af6a5.' (66ebfcf)
|
- This is the final step in making a transfer valid in the network. - Fees are paid to nodes. - NB1: Some additional validation of responses is needed to make sure we error if not enough nodes could handle the request. - NB2: Nodes still need to store the rewards in their wallet, TBD. - NB3: There are still some code reuse work to be done between transfer online and offline files.
- This keeps the logic levels more consistent - As client handling of transfers was already in protocol, it seems more stringent to also keep the node handling of transfers there.
We dial optional peers on startup that will get added to our routing table et al. This will cause our node to get booted by specifying a bootstrap node address.
- Adds deposit operation.
- This makes the main fn less cluttered.
- This makes the main fn less cluttered.
- We didn't want a separate binary for this.
This reverts commit 0765b53.
This reverts commit 70af6a5.
AI-Generated Summary: This pull request includes numerous changes related to renaming and restructuring the These updates include:
Overall, this pull request refines and extends the implementation of various aspects related to client transfers, node bootstrapping, and error handling, among others. |
I'm not sure this e2e setup is what we want atm. Could be nightly is sufficient, but I wanted to test the e2e ci runs for stability with these changes.
First run: e2e are complete before the unit tests, so doesn't look like there's significant drag there. If they are stable, I see no reason to have this only on a nightly run.
🤖 Generated by Copilot at 5744bee
Summary
🐛🚀🧪
This pull request adds network and e2e tests to the merge workflow, improves error handling and logging in the
safenode
package, and modifies the mdns configuration to speed up peer discovery. These changes aim to enhance the functionality, compatibility, and reliability of thesafe_network
project.Walkthrough