This repository has been archived by the owner on Apr 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 99
PIP-2675: Disable Batching and Force Global configuration #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Baliedge
force-pushed
the
Baliedge/PIP-2675-disable-batching
branch
from
September 29, 2023 19:43
86db0cc
to
66e8943
Compare
Baliedge
force-pushed
the
Baliedge/PIP-2675-disable-batching
branch
from
October 2, 2023 15:36
9027f13
to
56d48ce
Compare
Baliedge
force-pushed
the
Baliedge/PIP-2675-disable-batching
branch
from
October 2, 2023 17:10
56d48ce
to
2573caf
Compare
…more even workload distribution.
Baliedge
force-pushed
the
Baliedge/PIP-2675-disable-batching
branch
from
October 2, 2023 17:57
5123ddb
to
d7bc3a9
Compare
Baliedge
force-pushed
the
Baliedge/PIP-2675-disable-batching
branch
from
October 3, 2023 19:26
a31519d
to
01f0441
Compare
Baliedge
force-pushed
the
Baliedge/PIP-2675-disable-batching
branch
from
October 10, 2023 14:54
f1c6bc2
to
69f7e5a
Compare
Baliedge
changed the title
PIP-2675: Disable batching
PIP-2675: Disable Batching and Force Global configuration
Oct 10, 2023
MatthewEdge
approved these changes
Oct 10, 2023
thrawn01
approved these changes
Oct 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nit picks, but looks good!
Baliedge
force-pushed
the
Baliedge/PIP-2675-disable-batching
branch
from
October 10, 2023 19:03
da2120a
to
2d57822
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://mailgun.atlassian.net/browse/PIP-2675
Behaviors.DisableBatching = true
.Behaviors.ForceGlobal = true
.DisableBatching
setting.GlobalSyncWait
default from 500µs to 500ms to reduce global sync traffic.WorkerPool
command channels.WorkerPool
metrics:gubnernator_pool_queue_length
togubernator_worker_queue_length
.gubernator_command_counter
: Counter of commands executed inWorkerPool
.gubernator_check_counter
.gubernator_getratelimit_counter{calltype="local"}
.gubernator_global_queue_length
: Size of global broadcast queue.gubernator_broadcast_durations
togubernator_broadcast_duration
.gubernator_broadcast_counter
: Rate of global broadcasts. Labelcondition
may betimer
|queue_full
to indicate what triggered the broadcast.gubernator_concurrent_checks_counter
from summary to gauge type.gubernator_async_durations
togubernator_async_duration
.gubernator_asyncrequest_retries
togubernator_batch_retries
.gubernator_queue_length
togubernator_batch_queue_length
.