Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIP 2712: Reuse open telemetry interceptors #183

Merged
merged 2 commits into from
Nov 3, 2023
Merged

PIP 2712: Reuse open telemetry interceptors #183

merged 2 commits into from
Nov 3, 2023

Conversation

horkhe
Copy link
Member

@horkhe horkhe commented Nov 3, 2023 •
edited
Loading

  • Bug: Every time when a new gRPC connection is created a new pair of opentelementry interceptors is also created. Those interceptors are not released when the connection is closed. Over time the number of allocated interceptors grows causing a slow memory leak. The leak is particularly pronounced in bunker service that repeatedly creates disposable bunker clients to access data in other regions.
  • Also an optional WithLogger parameter was added to the grpcconn.NewConnMgr

Baliedge
Baliedge approved these changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@Baliedge Baliedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@horkhe horkhe merged commit 11436b5 into master Nov 3, 2023
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baliedge Baliedge Baliedge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@horkhe @Baliedge