Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DE-1356 Add revive linter #359

Merged
merged 56 commits into from
Dec 4, 2024
Merged

DE-1356 Add revive linter #359

merged 56 commits into from
Dec 4, 2024

Conversation

vtopc
Copy link
Contributor

@vtopc vtopc commented Dec 4, 2024

No description provided.

vtopc added 30 commits December 4, 2024 13:57
@vtopc
sort
4fc364a
@vtopc
unused-parameter
d590a92
@vtopc
unused-parameter
e2b8a67
@vtopc
increment-decrement
3a2817a
@vtopc
unused-parameter
d8d8ba4
@vtopc
empty-lines
826e0ed
@vtopc
enforce-slice-style
33f1d04
@vtopc
empty-lines
5e988ac
@vtopc
error-strings
bbde393
@vtopc
fmt
c71c002
@vtopc
empty-lines
a62bde2
@vtopc
empty-lines
1b14627
@vtopc
comments
64f0d0d
@vtopc
string-format
5a03ff8
@vtopc
bool-literal-in-expr: Boolean expression seems to always evaluate to …
1b77a7b 
…true (revive)

                                hasOne = hasOne || true
                                         ^
@vtopc
enforce-repeated-arg-type-style
a9d5382
@vtopc
unused-receiver
ec9f143
@vtopc
unused-receiver
e17b8bb
@vtopc
indent-error-flow: if block ends with a return statement, so drop thi…
dbabd3f 
…s else and outdent its block (revive)
@vtopc
indent-error-flow: if block ends with a return statement, so drop thi…
54c54c9 
…s else and outdent its block (revive)
@vtopc
bare-return
bdcf970
@vtopc
unchecked-type-assertion
79d45ce
@vtopc
defer in a loop
4a39e0e
@vtopc
defer in a loop
c7c0ba6
@vtopc
early-return
6c160c0
@vtopc
unused-receiver
ba294c3
@vtopc
unused-receiver
1de9ed9
@vtopc
import-shadowing
4b86323
@vtopc
var-declaration: should omit type *bool from declaration of var Unsub…
ba31236 
…scribed; it will be inferred from the right-hand side (revive)
@vtopc
import-shadowing
443fd14
vtopc added 26 commits December 4, 2024 14:43
@vtopc
import-shadowing
c1f9d35
@vtopc
import-shadowing
9d48857
@vtopc
var-declaration: should drop = nil from declaration of var All; it i…
ae4e0e5 
…s the zero value (revive)
@vtopc
empty-lines
7df5956
@vtopc
import-shadowing:
fdf81bd
@vtopc
empty-lines
5802549
@vtopc
enforce-repeated-arg-type-style: repeated argument type can be omitte…
c34b89b 
…d (revive)
@vtopc
enforce-repeated-arg-type-style: repeated argument type can be omitte…
f47256a 
…d (revive)
@vtopc
bare-return
bacfdea
@vtopc
empty-lines
976a571
@vtopc
bare-return: avoid using bare returns, please add return expressions …
c179f07 
…(revive)
@vtopc
unused-receiver
2466ffb
@vtopc
confusing-results: unnamed results of the same type may be confusing…
4e5c0a4 
…, consider using named results (revive)
@vtopc
empty-lines
8446bf8
@vtopc
unchecked-type-assertion
6a3f4a2
@vtopc
unused-receiver
f223ca7
@vtopc
import-shadowing
d6a1460
@vtopc
import-shadowing
d9e7aaa
@vtopc
enforce-repeated-arg-type-style
6c5f742
@vtopc
enforce-repeated-arg-type-style
bbe442b
@vtopc
unused-receiver
0d15bd5
@vtopc
import-shadowing
2fa3614
@vtopc
unused-parameter
6088630
@vtopc
unused-parameter
ed0e453
@vtopc
added revive
0901363
@vtopc
curlString
f37742d
@vtopc vtopc marked this pull request as ready for review December 4, 2024 13:09
@vtopc vtopc merged commit b3b8931 into master Dec 4, 2024
2 checks passed
@vtopc vtopc deleted the vtopc/DE-1356 branch December 4, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vtopc