Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(moonraker): PKGLIST variable rename #298

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

ada-phillips
Copy link
Contributor

@ada-phillips ada-phillips commented Aug 3, 2024

Replace PKGLIST with PACKAGES in moonraker module script, following the rename here: Arksine/moonraker@247640c

This change in the moonraker install script was causing a failure to run this module's script, resulting in image build failures.

Replace `PKGLIST` with `PACKAGES` in moonraker module script, following Arksine/moonraker@247640c
@KwadFan KwadFan self-requested a review August 4, 2024 04:56
@KwadFan KwadFan self-assigned this Aug 4, 2024
@KwadFan KwadFan added the bug Something isn't working label Aug 4, 2024
@KwadFan
Copy link
Member

KwadFan commented Aug 4, 2024

Thank you for your contribution.
Lets see if build tests run well, if they finish successful, I dont mind to merge asap

Copy link
Member

@KwadFan KwadFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KwadFan KwadFan merged commit 0d951e4 into mainsail-crew:develop Aug 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants