Add external lb (#772)

* Add external lb

* Move check for failed out of select

This was likely causing huge resource consumption as the default case is always evaluated.

* Internalize cleanup and wait for continual req to stop

* Ignore context cancelled errors

* Cleanup first cluster wide test

* Make steps more like migration guide and wait on dns

* Wait longer for AWS lb

* Remove return that prevents continual reqs

pkg/tests/ossm/setup.go

@@ -30,7 +30,6 @@ import (
 type Istio struct {
 	Name      string
 	Namespace string
-	Version   string
 }
 
 type SMCP struct {
@@ -103,7 +102,6 @@ func DefaultIstio() Istio {
 	return Istio{
 		Name:      env.GetIstioName(),
 		Namespace: env.GetIstioNamespace(),
-		Version:   env.GetIstioVersion(),
 	}
 }
 

pkg/tests/tasks/migration/enable-strict-mtls-peer-auth.yaml

@@ -0,0 +1,7 @@
+apiVersion: security.istio.io/v1
+kind: PeerAuthentication
+metadata:
+  name: default
+spec:
+  mtls:
+    mode: STRICT

pkg/tests/tasks/migration/main_test.go

@@ -28,6 +28,9 @@ var (
 	migrationGateway = "bookinfo-gateway.yaml"
 )
 
+//go:embed enable-strict-mtls-peer-auth.yaml
+var enableMTLSPeerAuth string
+
 func TestMain(m *testing.M) {
 	test.NewSuite(m).
 		Setup(ossm.BasicSetup).