Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to clap (4.x) derive #34

Closed
wants to merge 1 commit into from
Closed

Conversation

jrop
Copy link

@jrop jrop commented Nov 2, 2022

This PR takes advantage of more statically known type safety for CLI argument parsing, making use of clap's derive feature. I prefer this over so-called "stringly-typed" code, as less runtime checks have to be performed: i.e., there are notably less .unwrap()'s and if-guards for things that clap can check for automatically.

@jrop
Copy link
Author

jrop commented Nov 2, 2022

I didn't see that #32 already exists-- So feel free to close this in favor of that one!

@hwittenborn
Copy link
Member

hwittenborn commented Nov 2, 2022

I'm probably gonna close this so #32 can stay open like you said @jrop just because it was opened first. Thanks a ton for the work regardless though!

If you're still wanting to contribute code somehow, the Rust code in makedeb is still awaiting a TOML parser to be written in it. I planned on getting that done shortly, but if you'd want to tackle it on I'd be more than fine with that. There's also some commands that need to be added to Mist still if you'd want to look at those in the issues.

Regardless, thanks a ton for the work, it's really appreciated! :)

@hwittenborn hwittenborn closed this Nov 2, 2022
@jrop
Copy link
Author

jrop commented Nov 2, 2022

@hwittenborn That sounds interesting. Do you have more info regarding the needs of the TOML integration in makedeb? Perhaps we can continue this conversation on Matrix if that is more conducive (@jrop:matrix.org)

@hwittenborn
Copy link
Member

hwittenborn commented Nov 2, 2022

Yeah that sounds great - You're in the makedeb Matrix rooms already, right? If it's fine with you, we could just talk about it in #makedeb-project:hunterwittenborn.com.

I'm at school right now so I won't be able to do too much talking, but if you just want to ping me in there I'll respond right when I get the chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants