This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
Nullchecking addressing issue 23 #33
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `process` method no null checks even for `player` variable. Should address maksim789456#23 TODO: Add logging. Cause patching of this method can lead no sounds issue on client side.
Errata
Errata. forEach not a for loop.
AntonBoch1244
commented
Apr 20, 2023
| @@ -86,6 +81,8 @@ private void blockUpdates(Collection<BlockPos> blockPos) { | |||
|
|
|||
| @Override | |||
| protected void gatherDiagnostics(Collection<String> left, Collection<String> right, Collection<TimerEMA> timers) { | |||
| if (this.blockEffects == null || left == null) return; | |||
There was a problem hiding this comment.
Not included to commit message:
left must have value
this.blockEffects must have value
maksim789456
pushed a commit
that referenced
this pull request
Dec 17, 2023
* Remove BiomeAccessor * More cleanup * Fixup enum related codecs * Some doc cleanup * Fix derp --------- Co-authored-by: OreCruncher <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #23
Adding process and handlers null checks for address issues.