-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit, poetry and use type hinting #78
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR. I will be dedicating time for this project this upcoming week to handle this and many other issues. |
Finally doing a lot of work on this repo today. Not sure why you deleted init.py but the rest looks good. I am gonna test it out and see if its good. |
With regard to your comments, I think a keyboard shortcut or something of the like would be great. Yeah, the current implementation sometimes loses some words and punctuation context. |
I am not able to install this using poetry install. I am getting a message like: Package operations: 14 installs, 0 updates, 0 removals
RuntimeError Unable to find installation candidates for triton (2.3.1) at /opt/homebrew/Cellar/poetry/1.8.3_2/libexec/lib/python3.12/site-packages/poetry/installation/chooser.py:74 in choose_for Cannot install triton. |
Also, is it possible to install in editable form? Like pip install -e . |
I really like the other changes though. Let me know if you want to proceed. Otherwise I might add them in other ways. |
Hey, thanks for the awesome project.
I was considering adding support to allow a keyboard shortcut to toggle the start and end of a transcription session as I find that the
--loop
flag often results in poor transcriptions as sentences are randomly split and the model looses a lot of context.I created a PoC for this, but first wanted to tidy things up before making any major changes. I'm not sure you'll agree with the addition of
poetry
or all of yruff
rules, but it enforces homogeneity across the code as well as makes things easier to work with.Please let me know your thoughts and suggestions.
Kind regards,
Ben