join context callback handlers together

maloel · Oct 10, 2023 · 5799bdb · 5799bdb
1 parent bf03775
commit 5799bdb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 24 deletions.
diff --git a/src/context.cpp b/src/context.cpp
@@ -19,7 +19,6 @@ namespace librealsense
     context::context( json const & settings )
         : _settings( settings )
         , _device_mask( rsutils::json::get< unsigned >( settings, "device-mask", RS2_PRODUCT_LINE_ANY ) )
-        , _devices_changed_callback( nullptr, []( rs2_devices_changed_callback * ) {} )
     {
         static bool version_logged = false;
         if( ! version_logged )
@@ -106,31 +105,13 @@ namespace librealsense
                 kvp.second->on_devices_changed( new rs2_device_list( { shared_from_this(), rs2_devices_info_removed } ),
                                                 new rs2_device_list( { shared_from_this(), rs2_devices_info_added } ) );
             }
-            catch( ... )
-            {
-                LOG_ERROR( "Exception thrown from user callback handler" );
-            }
-        }
-
-        raise_devices_changed( rs2_devices_info_removed, rs2_devices_info_added );
-    }
-
-    void context::raise_devices_changed(const std::vector<rs2_device_info>& removed, const std::vector<rs2_device_info>& added)
-    {
-        if (_devices_changed_callback)
-        {
-            try
-            {
-                _devices_changed_callback->on_devices_changed(new rs2_device_list({ shared_from_this(), removed }),
-                    new rs2_device_list({ shared_from_this(), added }));
-            }
             catch( std::exception const & e )
             {
                 LOG_ERROR( "Exception thrown from user callback handler: " << e.what() );
             }
-            catch (...)
+            catch( ... )
             {
-                LOG_ERROR("Exception thrown from user callback handler");
+                LOG_ERROR( "Exception thrown from user callback handler" );
             }
         }
     }
@@ -153,7 +134,9 @@ namespace librealsense
     void context::set_devices_changed_callback(devices_changed_callback_ptr callback)
     {
         std::lock_guard<std::mutex> lock(_devices_changed_callbacks_mtx);
-        _devices_changed_callback = std::move(callback);
+        // unique_id::generate_id() will never be 0; so we use 0 for the "public" callback so it'll get overriden on
+        // subsequent calls
+        _devices_changed_callbacks[0] = std::move( callback );
     }
 
 

diff --git a/src/context.h b/src/context.h
@@ -76,7 +76,6 @@ namespace librealsense
     private:
         void invoke_devices_changed_callbacks( std::vector<rs2_device_info> & rs2_devices_info_removed,
                                                std::vector<rs2_device_info> & rs2_devices_info_added );
-        void raise_devices_changed(const std::vector<rs2_device_info>& removed, const std::vector<rs2_device_info>& added);
 
         std::map< std::string, std::weak_ptr< device_info > > _user_devices;
         std::map<uint64_t, devices_changed_callback_ptr> _devices_changed_callbacks;
@@ -86,7 +85,6 @@ namespace librealsense
 
         std::vector< std::shared_ptr< device_factory > > _factories;
 
-        devices_changed_callback_ptr _devices_changed_callback;
         std::mutex _devices_changed_callbacks_mtx;
     };