Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conda-build: Add workflow for Windows #2252

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from
Draft

conda-build: Add workflow for Windows #2252

wants to merge 33 commits into from

Conversation

jjerphan
Copy link
Collaborator

Reference Issues/PRs

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@jjerphan jjerphan added the patch Small change, should increase patch version label Mar 19, 2025
@jjerphan jjerphan force-pushed the build/windows-conda-build branch 7 times, most recently from 9e226d0 to 0520427 Compare March 20, 2025 10:09
@jjerphan jjerphan changed the title ci: Add workflow for Windows conda-build: Add workflow for Windows Mar 21, 2025
@jjerphan jjerphan force-pushed the build/windows-conda-build branch 5 times, most recently from 6bf1b60 to 099d3a5 Compare March 24, 2025 12:26
jjerphan added 15 commits March 24, 2025 13:58
@jjerphan
Add workflow for Windows
3a34d11 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Make sure to remove any existing vcpkg directory
b444fe8 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Use Ninja
1567e4c 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Initialize micromamba for bash and cmd.exe
5a88e1c 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Only install libarrow and pyarrow on Linux and macOS
8776821 
Due to clashes.

See: https://github.com/man-group/ArcticDB/actions/runs/13949564501/job/39045159340

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Change preset to windows-cl-conda-release
525502d 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Build without arrow on Windows
86bf9b4 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Conditionally define GLOG_USE_GLOG_EXPORT on Windows
2af51f3 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Use dynamic linkage
98c2474 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
debug: Use verbose mode for build systems
ec6b7cf 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Omit MSVC runtime checks for now
0cac0ab 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Do not include unused folly/gen/Base.h
9a9ef26 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Exclude custom PCRE resolution for conda builds
8cdb7c5 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Use PCRE_LIBRARIES variable
ae7b26f 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Build in parallel
c350372 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the build/windows-conda-build branch from 8f194ff to c350372 Compare March 24, 2025 13:05
@jjerphan jjerphan force-pushed the build/windows-conda-build branch 13 times, most recently from 27dd126 to cfbb45f Compare March 26, 2025 15:21
jjerphan added 11 commits March 26, 2025 16:57
@jjerphan
Define PROTOBUF_USE_DLLS
d122aff 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Adapt toolchain
eb05d21 
- Use cmd.exe instead of bash (cl is only usable from it)
- Use Ninja
- Unset `CMAKE_GENERATOR_PLATFORM` and `CMAKE_GENERATOR_TOOLSET`
(not needed and unsupported by Ninja)

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Do not promote warning 4189 to an error for conda builds
f0dfb3b 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Explicitly specify return type
0d67560 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Rework specification of flags for linkage and runtime
07d5048 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Using type aliases to help MSVC type inference
ef48435 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Explicitly pass sparse_missing_value_output to lambda
0ec809a 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Disable all workflows but the ones for Windows on conda
25b557c 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Remove upper bound on fmt
0082449 
See: conda-forge/fmt-feedstock#63

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Build with several threads
f4d060a 
Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan
Adapt signature of read_dataframe_from_file
5fbb6da 
Given:

```
2025-03-26T15:53:44.0857462Z D:\a\ArcticDB\ArcticDB\cpp\arcticdb\version\python_bindings.cpp(235): error C2440: 'return': cannot convert from 'pybind11::tuple (__cdecl *)(arcticdb::VariantId,const std::string,std::shared_ptr<arcticdb::pipelines::ReadQuery> &,const arcticdb::ReadOptions &)' to 'pybind11::tuple (__cdecl *)(arcticdb::VariantId,const std::string (__cdecl *)(void),std::shared_ptr<arcticdb::pipelines::ReadQuery> &,const arcticdb::ReadOptions &)'
2025-03-26T15:53:44.1099966Z D:\a\ArcticDB\ArcticDB\cpp\arcticdb\version\python_bindings.cpp(235): note: This conversion requires a reinterpret_cast, a C-style cast or function-style cast
2025-03-26T15:53:44.1430769Z D:\a\ArcticDB\ArcticDB\cpp\arcticdb\version\python_bindings.cpp(235): error C2440: 'return': cannot convert from 'pybind11::tuple (__vectorcall *)(arcticdb::VariantId,const std::string,std::shared_ptr<arcticdb::pipelines::ReadQuery> &,const arcticdb::ReadOptions &)' to 'pybind11::tuple (__vectorcall *)(arcticdb::VariantId,const std::string (__cdecl *)(void),std::shared_ptr<arcticdb::pipelines::ReadQuery> &,const arcticdb::ReadOptions &)'
2025-03-26T15:53:59.0922987Z D:\a\ArcticDB\ArcticDB\cpp\arcticdb\version\python_bindings.cpp(235): note: This conversion requires a reinterpret_cast, a C-style cast or function-style cast
```

Signed-off-by: Julien Jerphanion <[email protected]>
@jjerphan jjerphan force-pushed the build/windows-conda-build branch 3 times, most recently from abe2f08 to 6d038dc Compare March 27, 2025 08:03
@jjerphan jjerphan force-pushed the build/windows-conda-build branch from 6d038dc to a252a8e Compare March 27, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 will be requested when the pull request is marked ready for review alexowens90 is a code owner

@willdealtry willdealtry Awaiting requested review from willdealtry willdealtry will be requested when the pull request is marked ready for review willdealtry is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars will be requested when the pull request is marked ready for review poodlewars is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
patch Small change, should increase patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jjerphan