Replace inner html #166
Open
Replace inner html #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we render a provider without calling it, it places a small div in the document that loads the actual contents from `self.url` when it is revealed. Previously we were replacing the innerHTML (default) which left `hx-get` as a property on a parent div, which could then be inherited by its children. What we should be doing is replacing the entire small div with the contents of the block.
This doesn't really matter as far as I can tell, but it is neater to have the `<head>` before the contents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing an issue where nesting multiple
Tabblocks inside each other would cause a refresh of a parent element. By replacing the parent div usingouterHTMLthis is resolved.