Code written by Gum, this allows creatures to summon objects in scripts. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command show default calculated and DB stored coefficients for spell direct/dot heal/damage. (based on master commit 25fd98b) Re-apply with typo fix. (based on commit fda1f1d)
…st spell. (based on master commit 1710ac7) Drop some code not removed in original backport. (based on commit cefdbd8)
(based on master commit b0a9a93) (based on commit 4e9a71c)
(based on master commit 253d373) This is not need (unknown cases) for pre-3.x because absent BoA items but better have in sync with mangos master branch. (based on commit 14ebdf5)
…tions set. Signed-off-by: NoFantasy <[email protected]> (based on master commit 7e92078) (based on commit 310fd15)
(based on master commit 7468bb0) (based on master commit f5f52d9) (based on commit b03583a) Single missing case added.
* Some spells have StackAmount > 255, for example 22735 * Cleanup some weird type casts in _LoadAuras (based on master commit f425f61) (based on commit 5313734)
For leak detection you can also use tools like Valgrind. If you really want to use VLD you can revert this commit and remove the comments in MemoryLeaks.cpp and MemoryLeaks.h. The VLD version which has been shipped with MaNGOS is *heavily* outdated and I thus suggest you to use a newer version of it, if you really plan to use it. You can find the newest version on github in its official repository: https://github.com/dmoulding/vld (based on master commit d88b5ee) (based on commit 7e12ed2)
…es to CRLF line endings. Signed-off-by: DasBlub <[email protected]> (based on master commit f0ecccf) (based on commit f04b302)
(based on master commit 565963c) (based on commit ef81dcc)
(based on master commit a88d2b6) Posisble you will need install VC100 runtime. Look at Microsoft site. Signed-off-by: VladimirMangos <[email protected]> (based on commit 3376535)
Signed-off-by: DasBlub <[email protected]> (based on master commit 57a6b30) (based on commit 8109576)
Sometime levelup possible for dead player, prevent reset health in this case. (based on master commit b12d6ce) (based on commit fd45383)
Also make the -DPREFIX work on Win/MSVC Signed-off-by: Neo2003 <[email protected]> (based on master commit d4b156b) (based on commit 76d022d)
(based on commit dcbdc40) Also remove not existed in One files. (based on commit 8f736db) Also fix constant rebuild src/shared/Hmac.cpp
…quests. Should improve player save performance + lower MySQL server CPU usage. Note: PostgreSQL does not have prepared statements implemented using native APIs. Huge thanks to Undergarun, kero99 and Vinolentus. Signed-off-by: Ambal <[email protected]> (based on master commit bfdc943) (based on master commit 84358c5) (based on commit 2915c89)
(based on master commit 0b25669) (based on commit 4b7f742) Also simplify Spell::WriteSpellGoTargets using 1.x work specific.
Signed-off-by: VladimirMangos <[email protected]> (based on master commit a1f07bf) (based on commit e52dd88)
Signed-off-by: NoFantasy <[email protected]> (based on master commit 4215442) (based on commit e6028b9)
…rdinates. Possibly can help with freezes when 'DetectPosCollision = 1'. Signed-off-by: Ambal <[email protected]> (based on master commit a79ca96) (based on commit e1fed58)
- Unit::CalculateSpellDuration split into two functions
- CalculateSpellDuration taking into account combo points and caster-side spell mods
- Unit::CalculateAuraDuration taking into account target-side spell mods
- Diminishing is now applied before duration reduction mods
- Implement saving per-effect periodic timers to DB (required for auras affected by haste)
(based on master commit 09090ac)
(based on master commit 458f9ef)
(based on master commit 8c56f30)
(based on commit 0a82f06)
(based on commit 81bf612)
Signed-off-by: NoFantasy <[email protected]> (based on master commit 94cc133) (based on commit e13f4d6)
Signed-off-by: Ambal <[email protected]> (based on master commit b19cd2e) (based on commit ca857d8)
…of ignoring case. Thanks Ambal for finding i though... (based on master commit 48b130a) (based on commit 28849b0)
Signed-off-by: NoFantasy <[email protected]> (based on master commit 48111f9) (based on commit c7aac5e)
… to do the emote Also allow play emote on Player when player is source. Gameobject may be source of script but are only allowed as searcher for creature when defined. Signed-off-by: NoFantasy <[email protected]> (based on master commit 817a786) (based on commit f407a77)
Reserve at server startup some guods follow last used in static DB spawns guid for creatures/gameobjects for use in .npc add/.gobject add commands. This allow safe select guids not used in all map copies. Guids for temporary spawns used from range frollow after reserved guids range. This also let select new static spawns guids (added in game chat command) near to already used static guids. So it let avoid gaps in static guids lists. Amount reserved guids set in new GuidReserveSize.* config options. (based on master commit 761ca7a) (based on master commit 3e2a49e) (based on master commit 3ae892b) (based on master commit c2321b1) (based on commit 9a2ccef)
../docs/script_commands.txt updated for details Signed-off-by: NoFantasy <[email protected]> (based on master commit 3826557) (based on master commit dd564ce) (based on commit fc46751)
Signed-off-by: NoFantasy <[email protected]> (based on master commit 86d0319) (based on commit 02128cb)
…messages. (based on commit cb77118) Signed-off-by: Salja <[email protected]>
(based on commit b0ff049) Signed-off-by: Salja <[email protected]>
Signed-off-by: Laise <[email protected]> (based on commit 5eb8855) Signed-off-by: Salja <[email protected]>
In 1.12.1 we don't need to take care about multiple such spells as there is only one, spell 26802 (based on commit b58b29c) Signed-off-by: Salja <[email protected]>
Signed-off-by: Salja <[email protected]>
This reverts commit 6076ee78743386269f6a5e5d5781e6763283c5cf. Signed-off-by: Salja <[email protected]>
…: Shauren Signed-off-by: Salja <[email protected]>
Also * Move item comvert code from spell effect to new function. * Some code style cleanups. Signed-off-by: Salja <[email protected]>
Also drop battleground case that just same check in fact. Original patch and research provided by Den. Signed-off-by: Salja <[email protected]>
Signed-off-by: Sidsukana <[email protected]>
Signed-off-by: Sidsukana <[email protected]>
Signed-off-by: Salja <[email protected]>
…k) by Unlern Talents. Signed-off-by: Salja <[email protected]>
Removed references to TBC spell modifiers, and fixes compilation. Signed-off-by: TheLuda <[email protected]>
Signed-off-by: TheLuda <[email protected]>
…yer writing to them.
…ts. (huge help) Object.h is also changed, will add right now.
|
Discussed may times. The consensus is that there is no possible case where this is necessary. If you can provide one, please post it. Otherwise I'm closing this. |
|
Your kidding?? SomeAQ20 and AQ40 trash drop mining veins upon death... Sothos and jarien in Strath drop a lockbox upon death, which without this doesnt work on mangos..There are NPC's that upon death drop quest starting objects. The mining plans for Dark iron come from the ghost NPC in BRD. There are sooo many uses. What problems do you have with this? |
|
The problem is that it's a hackfix. If an object is always spawned in the same location, can be done in the database (ex. Sothos and Jarien's Heirlooms should be done in the DB). Smelting dark iron comes from an NPC via a spell. AQ20 and AQ40 dropping mining veins I've never heard of, you'll have to post an example. Spawning GOs in the same location = in the database with some scripting. If you can find an example where a GO must spawn dynamically and there is no spell... |
|
Dark iron smelting comes from a braizer spawned by the NPC next to him. Refer to these links for the mining in AQ20/40. http://www.wowhead.com/object=181069 and http://www.wowhead.com/object=181068 |
|
Obsidians are dropped by the 5 spells, all called Drop Obsidian. The dark iron smelting brazier can be done in the DB. Before you post any more examples, can you at least check if a spell exists first? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code written by Gum, this allows creatures to summon objects in scripts. (huge help)
Object.h is also changed, will add right now.