Call exec_podman in new thread, handle streaming logs whilst exited #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`podman logs --follow` doesn't always exit when the container exits, causing repo2docker to hang #6 This is reproducible with repo2docker images but not a simple image like busybox or nginx. This PR works around it by running `podman logs --follow` in a separate thread, and checking whether the container has exited in the main thread
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
podman logs --followdoesn't always exit when the container exits, causing repo2docker to hang#6
This is reproducible with repo2docker images but not a simple image like busybox or nginx.
This PR works around it by running
podman logs --followin a separate thread, and checking whether the container has exited in the main thread