-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
albumart #106
base: master
Are you sure you want to change the base?
albumart #106
Changes from 6 commits
6c5024d
a3cec45
d0210c1
ebd3a3e
943fc2d
25d1748
8e530b0
7acd0dd
ef838b4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -176,7 +176,21 @@ def tag(placeholders): | |
filename = substitute_placeholders(template, placeholders) | ||
podpath = os.path.join(placeholders.directory, filename) | ||
# ... and this is it | ||
|
||
# We also retrieve the path of a cover image, if there is one | ||
coverart = placeholders.feed.retrieve_config("coverart", False) | ||
if coverart: | ||
import mimetypes | ||
coverart_filename = substitute_placeholders(coverart, placeholders) | ||
if not os.path.exists(coverart_filename): | ||
print("""The file that I was supposed to use as cover art does not | ||
exist.""", file=sys.stderr, flush=True) | ||
coverart = False | ||
else: | ||
coverart_mime = mimetypes.guess_type(coverart_filename)[0] | ||
if not coverart_mime: | ||
print("""I couldn't guess the mimetype of this file, please use a | ||
more perspicuous extension""", file=sys.stderr, flush=True) | ||
coverart = False | ||
# now we create a dictionary of tags and values | ||
tagdict = placeholders.feed.defaulttagdict # these are the defaults | ||
try: # We do as if there was a section with potential tag info | ||
|
@@ -196,8 +210,12 @@ def tag(placeholders): | |
file_to_tag = eyed3.load(podpath) | ||
for mytag in tagdict: | ||
setattr(file_to_tag.tag, mytag, tagdict[mytag]) | ||
if coverart: | ||
with open(coverart_filename, 'rb') as imagefile: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be cool if the
or
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Right, let me look into that. |
||
image = imagefile.read() | ||
file_to_tag.tag.images.set( | ||
type_=3, img_data=image, mime_type=coverart_mime) | ||
file_to_tag.tag.save() | ||
|
||
|
||
|
||
def filtercond(placeholders): | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than guessing the MIME type from the extension, couldn’t we leverage mime-info on systems that have it? It’s more accurate in most cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g. using https://github.com/ahupp/python-magic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a bit wary of multiplying dependencies; also, users can pretty much choose their own extension with
file_to_tag
, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had assumed that EyeD3 bundled magic anyway for use with https://eyed3.readthedocs.io/en/latest/eyed3.plugins.html#module-eyed3.plugins.mimetype but looking at the source, it seems I was mistaken.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... but perhaps I'm being silly about dependencies. You seem to be a serious dev, much unlike me :) So I'm willing to listen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I think you’re being perfectly reasonable. Also I might be a serious dev (whatever that means) but not all that familiar with the Python ecosystem…