Only trigger discovery if the app has a repository

Signed-off-by: Sam Lucidi <[email protected]>
mansam · Jul 9, 2024 · 7c85d47 · 7c85d47
1 parent da9fca4
commit 7c85d47
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 37 deletions.
diff --git a/api/application.go b/api/application.go
@@ -249,18 +249,20 @@ func (h ApplicationHandler) Create(ctx *gin.Context) {
 		return
 	}
 
-	rtx := RichContext(ctx)
-	tr := trigger.Application{
-		Trigger: trigger.Trigger{
-			TaskManager: rtx.TaskManager,
-			Client:      rtx.Client,
-			DB:          h.DB(ctx),
-		},
-	}
-	err = tr.Created(m)
-	if err != nil {
-		_ = ctx.Error(err)
-		return
+	if r.Repository != nil {
+		rtx := RichContext(ctx)
+		tr := trigger.Application{
+			Trigger: trigger.Trigger{
+				TaskManager: rtx.TaskManager,
+				Client:      rtx.Client,
+				DB:          h.DB(ctx),
+			},
+		}
+		err = tr.Created(m)
+		if err != nil {
+			_ = ctx.Error(err)
+			return
+		}
 	}
 
 	h.Respond(ctx, http.StatusCreated, r)
@@ -388,18 +390,20 @@ func (h ApplicationHandler) Update(ctx *gin.Context) {
 		}
 	}
 
-	rtx := RichContext(ctx)
-	tr := trigger.Application{
-		Trigger: trigger.Trigger{
-			TaskManager: rtx.TaskManager,
-			Client:      rtx.Client,
-			DB:          h.DB(ctx),
-		},
-	}
-	err = tr.Updated(m)
-	if err != nil {
-		_ = ctx.Error(err)
-		return
+	if r.Repository != nil {
+		rtx := RichContext(ctx)
+		tr := trigger.Application{
+			Trigger: trigger.Trigger{
+				TaskManager: rtx.TaskManager,
+				Client:      rtx.Client,
+				DB:          h.DB(ctx),
+			},
+		}
+		err = tr.Updated(m)
+		if err != nil {
+			_ = ctx.Error(err)
+			return
+		}
 	}
 
 	h.Status(ctx, http.StatusNoContent)

diff --git a/importer/manager.go b/importer/manager.go
@@ -344,19 +344,22 @@ func (m *Manager) createApplication(imp *model.Import) (ok bool) {
 		imp.ErrorMessage = result.Error.Error()
 		return
 	}
-	// best effort
-	tr := trigger.Application{
-		Trigger: trigger.Trigger{
-			TaskManager: m.TaskManager,
-			Client:      m.Client,
-			DB:          m.DB,
-		},
-	}
-	err := tr.Created(app)
-	if err != nil {
-		imp.ErrorMessage = fmt.Sprintf(
-			"Failed to launch discovery tasks for Application '%s'.",
-			app.Name)
+
+	if repository.URL != "" {
+		// best effort
+		tr := trigger.Application{
+			Trigger: trigger.Trigger{
+				TaskManager: m.TaskManager,
+				Client:      m.Client,
+				DB:          m.DB,
+			},
+		}
+		err := tr.Created(app)
+		if err != nil {
+			imp.ErrorMessage = fmt.Sprintf(
+				"Failed to launch discovery tasks for Application '%s'.",
+				app.Name)
+		}
 	}
 
 	ok = true