add user details page

app/controllers/settings/users_controller.rb

@@ -1,13 +1,20 @@
 class Settings::UsersController < ApplicationController
+  before_action :get_user, except: [:index]
+
   def index
     @users = policy_scope(Federails::Actor).where(entity_type: "User")
     render layout: "settings"
   end
 
+  def show
+    render layout: "settings"
+  end
+
   private
 
   def get_user
-    policy_scope(User).find_param(:id)
+    @user = policy_scope(User).find_param(params[:id])
+    authorize @user
   end
 
   def user_params

app/views/settings/users/index.html.erb

@@ -6,7 +6,7 @@
   <tr>
     <th><%= User.human_attribute_name(:username) %></th>
     <th><%= User.human_attribute_name(:email) %></th>
-    <%= content_tag :th, t(".oidc") if SiteSettings.oidc_enabled? %>
+    <%= content_tag :th, User.human_attribute_name(:auth_uid) if SiteSettings.oidc_enabled? %>
     <%= content_tag :th, t(".local") if SiteSettings.federation_enabled? %>
     <%= content_tag :th, t(".fediverse_address") if SiteSettings.federation_enabled? %>
     <th><%= User.human_attribute_name(:roles) %></th>
@@ -16,11 +16,11 @@
     <tr>
       <td><%= user.entity.is_a?(User) ? user.entity.username : user.username %></td>
       <td><%= user.entity.is_a?(User) ? masked_email(user.entity.email) : nil %></td>
-      <%= content_tag :td, (user.auth_uid? ? "✅" : "❌") if SiteSettings.oidc_enabled? %>
+      <%= content_tag :td, (user.entity.auth_uid ? "✅" : "❌") if SiteSettings.oidc_enabled? %>
       <%= content_tag :td, (user.local? ? "✅" : "❌") if SiteSettings.federation_enabled? %>
       <%= content_tag :td, user.at_address if SiteSettings.federation_enabled? %>
       <td><%= user.entity.roles.map(&:name).join(", ") if user.entity.is_a?(User) %></td>
-      <td><%= link_to safe_join([icon("pencil", t("general.edit")), t("general.edit")], " "), settings_user_path(user), class: "btn btn-primary" %></td>
+      <td><%= link_to safe_join([icon("search", t(".view")), t(".view")], " "), settings_user_path(user.entity), class: "btn btn-primary" %></td>
     </tr>
   <% end %>
 </table>

app/views/settings/users/show.html.erb

@@ -0,0 +1,44 @@
+<h3><%= t(".title", username: @user.username ) %></h3>
+<table class="table table-striped">
+  <tr>
+    <th><%= User.human_attribute_name(:username) %></th>
+    <td><%= @user.username %></td>
+  </tr>
+  <tr>
+    <th><%= User.human_attribute_name(:email) %></th>
+    <td><%= @user.email %></td>
+  </tr>
+  <tr>
+    <th><%= User.human_attribute_name(:created_at) %></th>
+    <td><%= @user.created_at.to_fs(:long) %></td>
+  </tr>
+  <tr>
+    <th><%= User.human_attribute_name(:updated_at) %></th>
+    <td><%= @user.updated_at.to_fs(:long) %></td>
+  </tr>
+  <tr>
+    <th><%= User.human_attribute_name(:interface_language) %></th>
+    <td><%= @user.interface_language.present? ? I18nData.languages(@user.interface_language)[@user.interface_language.to_s]&.capitalize : t("devise.registrations.general_settings.interface_language.autodetect") %></td>
+  </tr>
+  <% if SiteSettings.oidc_enabled? %>
+    <tr>
+      <th><%= User.human_attribute_name(:auth_uid) %></th>
+      <td><%= (user.auth_uid ? "✅" : "❌") %></td>
+    </tr>
+  <% end %>
+  <% if SiteSettings.federation_enabled? %>
+    <tr>
+      <th><%= t("settings.users.index.fediverse_address") %></th>
+      <td><%= @user.actor.at_address %></td>
+    </tr>
+  <% else %>
+    <tr>
+      <th><%= User.human_attribute_name(:public_id) %></th>
+      <td><%= @user.public_id %></td>
+    </tr>
+  <% end %>
+  <tr>
+    <th><%= User.human_attribute_name(:roles) %></th>
+    <td><%= @user.roles.map(&:name).join(", ") %></td>
+  </tr>
+</table>

config/locales/settings/en.yml

@@ -70,4 +70,10 @@ en:
       success: Settings saved.
     users:
       index:
+        description: View and edit registered user accounts.
         title: Manage Users
+        fediverse_address: Fediverse address
+        local: Local
+        view: View
+      show:
+        title: "User details: %{username}"

spec/requests/settings/users_spec.rb

@@ -8,4 +8,14 @@
       expect(response).to be_successful
     end
   end
+
+  describe "GET /show" do
+    it "renders a successful response" do
+      user = Settings::User.create! valid_attributes
+      get user_url(user)
+      expect(response).to be_successful
+    end
+  end
+
+  describe "GET /new" do
 end

spec/routing/moderation/users_routing_spec.rb

@@ -5,5 +5,9 @@
     it "routes to #index" do
       expect(get: "/settings/users").to route_to("settings/users#index")
     end
+
+    it "routes to #show" do
+      expect(get: "/settings/users/1").to route_to("settings/users#show", id: "1")
+    end
   end
 end