This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
fix #247 #277
Merged
fix #247 #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, will review this today. Ideally I can figure out why this change broke it. Thanks for digging into this! |
tmcw
added a commit
that referenced
this pull request
Jun 1, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tmcw - in your court to review/modify/merge.
This fixes #247 by rolling back the renderer.js code to the last working version of
inheritDefinitions(previously calledinheritRules). I don't understand why it fixes it but the new regression tests confirm it is fixed and all other tests pass (likely due to such little attachment test coverage as per #245).