-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement in
expression
#7197
Closed
Closed
Implement in
expression
#7197
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f0d558a
Implement `in` expression
brncsk eaa9f37
Update docs
brncsk 9fc5b1d
Refrain from using ES6 Array.prototype.includes()
brncsk 155e962
Update expression metadata
brncsk 0856505
Corretly distinguish between old-style filter `in` and new-style expr…
brncsk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
// @flow | ||
|
||
import { array, ValueType, BooleanType } from '../types'; | ||
|
||
import type { Expression } from '../expression'; | ||
import type ParsingContext from '../parsing_context'; | ||
import type EvaluationContext from '../evaluation_context'; | ||
import type { Type } from '../types'; | ||
import type { Value } from '../values'; | ||
|
||
class In implements Expression { | ||
type: Type; | ||
needle: Expression; | ||
haystack: Expression; | ||
|
||
constructor(needle: Expression, haystack: Expression) { | ||
this.type = BooleanType; | ||
this.needle = needle; | ||
this.haystack = haystack; | ||
} | ||
|
||
static parse(args: Array<mixed>, context: ParsingContext) { | ||
if (args.length !== 3) | ||
return context.error(`Expected 2 arguments, but found ${args.length - 1} instead.`); | ||
|
||
const needle = context.parse(args[1], 1, ValueType); | ||
const haystack = context.parse(args[2], 2, array(ValueType)); | ||
|
||
if (!needle || !haystack) return null; | ||
|
||
return new In(needle, haystack); | ||
} | ||
|
||
evaluate(ctx: EvaluationContext) { | ||
const needle = (this.needle.evaluate(ctx): any); | ||
const haystack = ((this.haystack.evaluate(ctx): any): Array<Value>); | ||
|
||
return haystack.indexOf(needle) >= 0; | ||
} | ||
|
||
eachChild(fn: (Expression) => void) { | ||
fn(this.needle); | ||
fn(this.haystack); | ||
} | ||
|
||
possibleOutputs() { | ||
return [true, false]; | ||
} | ||
|
||
serialize() { | ||
return ["in", this.needle.serialize(), this.haystack.serialize()]; | ||
} | ||
} | ||
|
||
export default In; | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
{ | ||
"expression": [ | ||
"boolean", | ||
["in", ["get", "i"], ["array", ["get", "arr"]]] | ||
], | ||
"inputs": [ | ||
[{}, {"properties": {"i": null, "arr": [9, 8, 7]}}], | ||
[{}, {"properties": {"i": 1, "arr": [9, 8, 7]}}], | ||
[{}, {"properties": {"i": 9, "arr": [9, 8, 7]}}], | ||
[{}, {"properties": {"i": 1, "arr": null}}] | ||
], | ||
"expected": { | ||
"compiled": { | ||
"result": "success", | ||
"isFeatureConstant": false, | ||
"isZoomConstant": true, | ||
"type": "boolean" | ||
}, | ||
"outputs": [ | ||
false, | ||
false, | ||
true, | ||
{"error":"Expected value to be of type array, but found null instead."} | ||
], | ||
"serialized": [ | ||
"boolean", | ||
["in", ["get", "i"], ["array", ["get", "arr"]]] | ||
] | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can imagine us adding a collator argument to
"in"
. We introduced a bug when we we did that for string comparison operators. Let's future-proof this line by checkingfilter.length >= 3
.