Skip to content

Commit

Permalink
fix:added the latency-correction option to oha (#1732)
Browse files Browse the repository at this point in the history
This fixes this issue in our benchmarking via `oha`

> `--latency-correction`
> Correct latency to avoid coordinated omission problem.
  
=> explained here
https://youtu.be/lJ8ydIuPFeU?si=Z1FOLZ0U9i4qWl69&t=1201
  • Loading branch information
CommanderStorm authored Mar 8, 2025
1 parent 8f3275c commit 31fc566
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -119,12 +119,12 @@ bench-server: start
bench-http: (cargo-install "oha")
@echo "ATTENTION: Make sure Martin was started with just bench-server"
@echo "Warming up..."
oha -z 5s --no-tui http://localhost:3000/function_zxy_query/18/235085/122323 > /dev/null
oha -z 60s http://localhost:3000/function_zxy_query/18/235085/122323
oha -z 5s --no-tui http://localhost:3000/png/0/0/0 > /dev/null
oha -z 60s http://localhost:3000/png/0/0/0
oha -z 5s --no-tui http://localhost:3000/stamen_toner__raster_CC-BY-ODbL_z3/0/0/0 > /dev/null
oha -z 60s http://localhost:3000/stamen_toner__raster_CC-BY-ODbL_z3/0/0/0
oha --latency-correction -z 5s --no-tui http://localhost:3000/function_zxy_query/18/235085/122323 > /dev/null
oha --latency-correction -z 60s http://localhost:3000/function_zxy_query/18/235085/122323
oha --latency-correction -z 5s --no-tui http://localhost:3000/png/0/0/0 > /dev/null
oha --latency-correction -z 60s http://localhost:3000/png/0/0/0
oha --latency-correction -z 5s --no-tui http://localhost:3000/stamen_toner__raster_CC-BY-ODbL_z3/0/0/0 > /dev/null
oha --latency-correction -z 60s http://localhost:3000/stamen_toner__raster_CC-BY-ODbL_z3/0/0/0

# Run all tests using a test database
test: start (test-cargo "--all-targets") test-doc test-int
Expand Down

0 comments on commit 31fc566

Please sign in to comment.